[PATCH] Unbalanced parenthesis in _urls

[PATCH] Unbalanced parenthesis in _urls

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 61 bytes --]

Another fallout from workers/35168 , patch attached.

ismail

[-- Attachment #2: url-parens.patch --]
[-- Type: text/x-patch, Size: 432 bytes --]

Index: zsh/Completion/Unix/Type/_urls
===================================================================
--- zsh.orig/Completion/Unix/Type/_urls
+++ zsh/Completion/Unix/Type/_urls
@@ -75,7 +75,7 @@ fi
 scheme="$match[1]"
 
 case "$scheme" in
-  http(|s)|(|s)ftp|scp|gopher)
+  (http(|s)|(|s)ftp|scp|gopher)
     if ! compset -P //; then
       _wanted -C "$scheme" prefixes expl 'end of prefix' compadd -S '' "$@" //
       return

Re: [PATCH] Unbalanced parenthesis in _urls

[Peter Stephenson]

On Wed, 20 May 2015 15:03:21 +0300
İsmail Dönmez <ismail@donmez.ws> wrote:
> Another fallout from workers/35168 , patch attached.

I'm happy to apply these if they're causing issues, but the parenthesis
problem will need sorting out properly, so don't bother seeking things
out.

pws

Re: [PATCH] Unbalanced parenthesis in _urls

[İsmail Dönmez]

On Wed, May 20, 2015 at 3:54 PM, Peter Stephenson
<p.stephenson@samsung.com> wrote:
> On Wed, 20 May 2015 15:03:21 +0300
> İsmail Dönmez <ismail@donmez.ws> wrote:
>> Another fallout from workers/35168 , patch attached.
>
> I'm happy to apply these if they're causing issues, but the parenthesis
> problem will need sorting out properly, so don't bother seeking things
> out.

Well rather than seeking out, it hit me with curl completion :-) Feel
free to discard for now.

ismail

Re: [PATCH] Unbalanced parenthesis in _urls

[Peter Stephenson]

On Wed, 20 May 2015 15:57:14 +0300
İsmail Dönmez <ismail@donmez.ws> wrote:
> On Wed, May 20, 2015 at 3:54 PM, Peter Stephenson
> <p.stephenson@samsung.com> wrote:
> > On Wed, 20 May 2015 15:03:21 +0300
> > İsmail Dönmez <ismail@donmez.ws> wrote:
> >> Another fallout from workers/35168 , patch attached.
> >
> > I'm happy to apply these if they're causing issues, but the parenthesis
> > problem will need sorting out properly, so don't bother seeking things
> > out.
> 
> Well rather than seeking out, it hit me with curl completion :-) Feel
> free to discard for now.

I've committed it --- please feel free to send a patche if it hits you
again.

pws