zsh-workers
 help / color / mirror / code / Atom feed
* Remove systemd completion: provided by upstream
@ 2015-05-27 19:18 Daniel Hahler
  2015-05-27 22:06 ` Daniel Hahler
  2015-05-28  8:45 ` Peter Stephenson
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Hahler @ 2015-05-27 19:18 UTC (permalink / raw)
  To: Zsh Hackers' List

I've noticed that systemd maintains its own systemd completion, which seems to be well
maintained.

It is installed into /usr/share/zsh/vendor-completions, which I had to manually add to
my $fpath (because I build Zsh myself), but it would be there already for the Zsh
from Ubuntu.

Therefore the completion in Zsh (Completion/Unix/Command/_systemd) should be removed
probably.

Given that this is the case, would it still require to send the patch for this to the
mailinglist before removing it from Git?


Regards,
Daniel.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Remove systemd completion: provided by upstream
  2015-05-27 19:18 Remove systemd completion: provided by upstream Daniel Hahler
@ 2015-05-27 22:06 ` Daniel Hahler
  2015-05-28  8:45 ` Peter Stephenson
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Hahler @ 2015-05-27 22:06 UTC (permalink / raw)
  To: zsh-workers; +Cc: Eric Cook

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

For reference, the completion provided by systemd is at:
http://cgit.freedesktop.org/systemd/systemd/tree/shell-completion/zsh

It seems to be based on the one from Zsh, at least I've found that this is the case 
for _filter_units_by_property (used in _systemctl).


Cheers,
Daniel.

On 27.05.2015 21:18, Daniel Hahler wrote:
> I've noticed that systemd maintains its own systemd completion, which seems to be well
> maintained.
> 
> It is installed into /usr/share/zsh/vendor-completions, which I had to manually add to
> my $fpath (because I build Zsh myself), but it would be there already for the Zsh
> from Ubuntu.
> 
> Therefore the completion in Zsh (Completion/Unix/Command/_systemd) should be removed
> probably.
> 
> Given that this is the case, would it still require to send the patch for this to the
> mailinglist before removing it from Git?
> 
> 
> Regards,
> Daniel.
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iD8DBQFVZj/LfAK/hT/mPgARAm8xAKCHtDOu8WanNZg8z0bwfQz59sZq2gCdF42l
c03Gj0FXUNl6IG/CIvd4A9o=
=EABh
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Remove systemd completion: provided by upstream
  2015-05-27 19:18 Remove systemd completion: provided by upstream Daniel Hahler
  2015-05-27 22:06 ` Daniel Hahler
@ 2015-05-28  8:45 ` Peter Stephenson
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Stephenson @ 2015-05-28  8:45 UTC (permalink / raw)
  To: Zsh Hackers' List

Removing systemd completion to avoid a clash with the systemd-maintained
version...

On Wed, 27 May 2015 21:18:32 +0200
Daniel Hahler <genml+zsh-workers@thequod.de> wrote:
> Given that this is the case, would it still require to send the patch
> for this to the mailinglist before removing it from Git?

Meant to reply to this: no, it's not.  Just mention the post where you
gave the reasons for removing it.

pws


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-28  8:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-27 19:18 Remove systemd completion: provided by upstream Daniel Hahler
2015-05-27 22:06 ` Daniel Hahler
2015-05-28  8:45 ` Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).