From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Arith parsing bug with minus after $#
Date: Fri, 29 May 2015 16:02:37 +0100 [thread overview]
Message-ID: <20150529160237.6f329071@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <55676FB1.9080401@inlv.org>
On Thu, 28 May 2015 21:42:41 +0200
Martijn Dekker <martijn@inlv.org> wrote:
> % set --
> % echo $#
> 0
> % echo $(($#-1))
> 41
That's not a compatibility issue, that's just plain weird. I don't know
the POSIX terminology.
The problem is the overloading of "#" --- the test to establish what to
do with it is trying too hard to resolve to ${#-}, which is a valid
substitution, because it hasn't taken into account that there are no
braces. So what you're seeing is ${#-}1.
"-" is overloaded, too, so there could be other cases involving those
two characters where they're misinterpreted, even with braces.
diff --git a/Src/subst.c b/Src/subst.c
index d4a04b8..168f7f1 100644
--- a/Src/subst.c
+++ b/Src/subst.c
@@ -2170,7 +2170,7 @@ paramsubst(LinkList l, LinkNode n, char **str, int qt, int pf_flags)
*/
|| ((cc == '#' || cc == Pound) &&
s[2] == Outbrace)
- || cc == '-' || (cc == ':' && s[2] == '-')
+ || (inbrace && (cc == '-' || (cc == ':' && s[2] == '-')))
|| (isstring(cc) && (s[2] == Inbrace || s[2] == Inpar)))) {
getlen = 1 + whichlen, s++;
/*
diff --git a/Test/D04parameter.ztst b/Test/D04parameter.ztst
index d96ffb6..c41e05e 100644
--- a/Test/D04parameter.ztst
+++ b/Test/D04parameter.ztst
@@ -1703,3 +1703,8 @@
funnychars='The qu*nk br!wan f@x j/mps o[]r \(e la~# ^"&;'
[[ $funnychars = ${~${(b)funnychars}} ]]
0:${(b)...} quoting protects from GLOB_SUBST
+
+ set --
+ print $#-1
+0:Avoid confusion after overloaded characters in braceless substitution
+>0-1
next prev parent reply other threads:[~2015-05-29 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 19:42 Martijn Dekker
2015-05-29 15:02 ` Peter Stephenson [this message]
2015-05-29 15:43 ` Martijn Dekker
2015-05-29 18:09 ` Bart Schaefer
2015-05-29 19:33 ` Martijn Dekker
2015-05-29 20:48 ` ZyX
2015-05-29 21:24 ` Bart Schaefer
2015-05-30 19:24 ` Peter Stephenson
2015-05-30 19:40 ` Peter Stephenson
2015-05-30 22:28 ` Bart Schaefer
2015-05-30 23:30 ` Peter Stephenson
2015-06-07 1:08 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529160237.6f329071@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).