zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: zsh 5.0.8 available (preliminary announcement)
Date: Tue, 02 Jun 2015 11:22:55 +0100	[thread overview]
Message-ID: <20150602112255.79bd4e03@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20175.1433239580@thecus.kiddle.eu>

On Tue, 2 Jun 2015 12:06:20 +0200
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Is the -o option to test safe to use in configure? It seems existing
> tests use || and && but the precedence of those wouldn't be right.

I think the definitive answer is "probably, who knows?"  configure has
been written to handle some very ancient implementations of test, but
the things it's more likely to fall down on are what happens with
confusing arguments (as zsh still sometimes does or did), which doesn't
apply here.  You might find better guidance in the autoconf
documentation if there's none in the existing code.

The ultra paranoid way to do it is nest the ifs...

if  test1 || test2; then
  if test3 && test4 && test5 ..; then
    stuff
    done_some_stuff=yes
  fi
fi
if test x$done_some_stuff != xyes; then
  alternative stuff
fi

I committed Baptiste's patch, it looks like you might want to back it
off.

pws


  reply	other threads:[~2015-06-02 10:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-31 18:23 Peter Stephenson
2015-05-31 23:19 ` Martijn Dekker
2015-06-01  0:17 ` Bart Schaefer
2015-06-01 22:13   ` Baptiste Daroussin
2015-06-02  5:47     ` Baptiste Daroussin
2015-06-02 10:06     ` Oliver Kiddle
2015-06-02 10:22       ` Peter Stephenson [this message]
2015-06-02 10:26       ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150602112255.79bd4e03@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).