From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28434 invoked by alias); 19 Jun 2015 13:14:12 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35524 Received: (qmail 11703 invoked from network); 19 Jun 2015 13:14:10 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.0 Date: Fri, 19 Jun 2015 06:01:43 -0700 From: Danek Duvall To: Oliver Kiddle Cc: zsh-workers@zsh.org Subject: Re: [PATCH] _file_descriptors: initialize `list' array with local -a Message-ID: <20150619130143.GC17684@lorien.comfychair.org> Mail-Followup-To: Danek Duvall , Oliver Kiddle , zsh-workers@zsh.org References: <1434432668-18303-1-git-send-email-llua@gmx.com> <22433.1434440572@thecus.kiddle.eu> <558047B6.4090908@gmx.com> <29394.1434553069@thecus.kiddle.eu> <2672.1434663222@thecus.kiddle.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2672.1434663222@thecus.kiddle.eu> User-Agent: Mutt/1.5.20 (2010-04-22) On Thu, Jun 18, 2015 at 11:33:42PM +0200, Oliver Kiddle wrote: > I wrote: > > The updated function looks good. One slight issue is that description > > separators don't align now that two digit fds are included: > > I was going to commit this with that small tweak but noticed that it > also needed to handle sorting manually so that e.g. 10 is placed after > 3. Given a few further tweaks and the addition of pfiles use for > Solaris it seems necessary to post a patch. Newer versions of Solaris (11 and up?) have /proc//path/<->, which have the same effect as the symlinks in /proc//fd on Linux. Danek