From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19395 invoked by alias); 22 Jun 2015 08:36:52 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35563 Received: (qmail 10678 invoked from network); 22 Jun 2015 08:36:48 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.0 X-AuditID: cbfec7f5-f794b6d000001495-e3-5587c91b4fb6 Date: Mon, 22 Jun 2015 09:36:44 +0100 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: [PATCH] allocate origline by ztrdup(), not by dupstring() Message-id: <20150622093644.4fb9cd0b@pwslap01u.europe.root.pri> In-reply-to: <4F8A1056-198B-4CF1-A167-7C3060F77B10@kba.biglobe.ne.jp> References: <1000D010-B07A-4F19-A566-8CA95B061D58@kba.biglobe.ne.jp> <24973.1434473665@thecus.kiddle.eu> <4F8A1056-198B-4CF1-A167-7C3060F77B10@kba.biglobe.ne.jp> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t/xa7rSJ9tDDS6fs7Y42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGU+a37EUNLBU3Jn5i72BcSZzFyMnh4SAicST/S2MELaYxIV7 69m6GLk4hASWMkpcXfmHBcKZwSSx9GYHlLONUWLarUlMIC0sAqoSyzpfsYDYbAKGElM3zQYb JSIgLnF27XmwuLCAm8S/e+vAbF4Be4nJf5+ygticAq4ST868YIdb9+nqQ7Ch/AL6Elf/fmKC uMleYuaVM4wQzYISPybfAxvELKAlsXlbEyuELS+xec1bsH+EBNQlbtzdzT6BUWgWkpZZSFpm IWlZwMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMkcL/uYFx6zOoQowAHoxIP7wz79lAh 1sSy4srcQ4wSHMxKIrwGU4BCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeWfueh8iJJCeWJKanZpa kFoEk2Xi4JRqYAz6dXqtkkVLh/O7rNS/Xy22qRju3h+9ilVnnTf/qe7XTA2pP3niTv2VzzJW 7/ik7bZUI2SG3sO53RODV9Z6POex0PdyNTfwnH76q+6CHkfJMN/zv2K7lJtMP51nqJl1+Ki/ gahs2Y7ZhyWz5NtZl6y2s73RmRbD3zEr7MG+PVu+qL+8Kt9+SYmlOCPRUIu5qDgRAJKREx9Y AgAA On Sun, 21 Jun 2015 20:53:49 +0900 Jun T. wrote: > 2015/06/17 01:54, Oliver Kiddle wrote: > > > This part is run when pressing backspace, it seems to always be the case > > that origline == u->origline before this block runs. So it is copying freed > > memory. > > Backspace (in the interactive mode) seems to work as expected with the > following patch. Does this look reasonable? I certainly can't see how this could have bad effects. pws