From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: Typeset with array
Date: Thu, 25 Jun 2015 16:39:32 +0100 [thread overview]
Message-ID: <20150625163932.0ca086c8@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <150625081653.ZM20153@torch.brasslantern.com>
On Thu, 25 Jun 2015 08:16:53 -0700
> Some quick tests:
>
> torch% typeset var var[2]=two
> torch% typeset -p var
> typeset var=two
That's correct: var is created then manipulated as a scalar. Apart from
localness this is the same effect as
var=
var[2]=two
> torch% typeset -a array array[2]=two
> typeset: array[2]: inconsistent type for assignment
> torch% typeset -p array
> typeset -a array
> array=()
That's also correct. typeset -a creates arrays, so "array" is
successfully created; however, array[2] is a scalar with a scalar
assignment, so that's an error with the "-a". (However, if you think
you can work out how to relax the test to allow array elements without
the whole thing blowing up in your face, be my guest...)
> torch% typeset newarray=() newarray[2]=two
That's the right way to mix arrays and scalars...
> zsh: segmentation fault (core dumped) Src/zsh -f
..so, as it happens, that's not correct. That reminds me of something
else I meant to test...
diff --git a/Src/exec.c b/Src/exec.c
index 57e8f63..50a11eb 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -3583,15 +3583,18 @@ execcmd(Estate state, int input, int output, int how, int last1)
asg->value.array =
ecgetlist(state, WC_ASSIGN_NUM(ac),
EC_DUPTOK, &htok);
- prefork(asg->value.array, PREFORK_ASSIGN);
- if (errflag) {
- state->pc = opc;
- break;
- }
- globlist(asg->value.array, 0);
- if (errflag) {
- state->pc = opc;
- break;
+ if (asg->value.array)
+ {
+ prefork(asg->value.array, PREFORK_ASSIGN);
+ if (errflag) {
+ state->pc = opc;
+ break;
+ }
+ globlist(asg->value.array, 0);
+ if (errflag) {
+ state->pc = opc;
+ break;
+ }
}
}
diff --git a/Test/B02typeset.ztst b/Test/B02typeset.ztst
index e6285bc..1548b81 100644
--- a/Test/B02typeset.ztst
+++ b/Test/B02typeset.ztst
@@ -663,3 +663,16 @@
>fn2 () {
> typeset assignfirst=(why not)
>}
+
+ fn() {
+ typeset array=()
+ print ${(t)array} ${#array}
+ typeset gnothergarray=() gnothergarray[1]=yes gnothergarray[2]=no
+ print -l ${(t)gnothergarray} $gnothergarray
+ }
+ fn
+0:can set empty array
+>array-local 0
+>array-local
+>yes
+>no
next prev parent reply other threads:[~2015-06-25 15:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5578996E.3080700@thequod.de>
[not found] ` <150610191427.ZM30841@torch.brasslantern.com>
[not found] ` <5579C247.1060800@thequod.de>
[not found] ` <150611183639.ZM32247@torch.brasslantern.com>
[not found] ` <20150612094237.338f79d5@pwslap01u.europe.root.pri>
2015-06-19 11:39 ` Peter Stephenson
2015-06-19 14:06 ` Peter Stephenson
2015-06-19 18:54 ` Bart Schaefer
2015-06-19 20:16 ` Peter Stephenson
2015-06-19 21:11 ` Eric Cook
2015-06-19 16:09 ` Bart Schaefer
2015-06-19 20:32 ` Peter Stephenson
2015-06-20 3:50 ` Bart Schaefer
2015-06-20 17:05 ` Peter Stephenson
2015-06-19 17:36 ` Oliver Kiddle
2015-06-19 18:40 ` Bart Schaefer
2015-06-25 9:29 ` Peter Stephenson
2015-06-25 15:16 ` Bart Schaefer
2015-06-25 15:39 ` Peter Stephenson [this message]
2015-06-25 16:08 ` Bart Schaefer
2015-06-25 16:34 ` Peter Stephenson
2015-06-26 13:51 ` PATCH: array slice Peter Stephenson
2015-06-26 23:07 ` Bart Schaefer
2015-06-27 19:42 ` Peter Stephenson
2015-06-27 20:09 ` Bart Schaefer
2015-06-26 16:46 ` PATCH: typeset completion Peter Stephenson
2015-06-26 19:14 ` Typeset with array Oliver Kiddle
2015-06-27 16:33 ` Peter Stephenson
2015-06-21 20:05 ` Peter Stephenson
2015-06-21 20:38 ` Peter Stephenson
2015-06-23 16:47 ` Peter Stephenson
2015-06-23 17:52 ` Mikael Magnusson
2015-06-23 20:17 ` Bart Schaefer
2015-06-23 20:21 ` Peter Stephenson
2015-06-23 20:24 ` Mikael Magnusson
2015-06-24 1:35 ` typeset -p with assoc array (was Re: Typeset with array) Bart Schaefer
2015-06-24 6:03 ` Bart Schaefer
2015-06-23 20:25 ` Typeset with array Bart Schaefer
2015-06-24 9:14 ` Peter Stephenson
2015-06-24 9:29 ` Peter Stephenson
2015-06-24 10:35 ` Roman Neuhauser
2015-06-24 13:00 ` Mikael Magnusson
2015-06-24 13:20 ` Peter Stephenson
2015-06-24 15:03 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625163932.0ca086c8@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).