From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: '>>' does not create file if set -C (noclobber) is active
Date: Sat, 27 Jun 2015 18:02:30 +0100 [thread overview]
Message-ID: <20150627180230.5fda7e09@ntlworld.com> (raw)
In-Reply-To: <558D5E34.3020505@inlv.org>
This isn't very elegant, but nor is it obviously problematic, and it
does at least draw attention to a potential issue.
pws
diff --git a/Doc/Zsh/options.yo b/Doc/Zsh/options.yo
index 2371e35..6dd2239 100644
--- a/Doc/Zsh/options.yo
+++ b/Doc/Zsh/options.yo
@@ -1819,6 +1819,20 @@ Make the tt(echo) builtin compatible with the BSD manref(echo)(1) command.
This disables backslashed escape sequences in echo strings unless the
tt(-e) option is specified.
)
+pindex(CLOBBER_APPEND)
+pindex(NO_CLOBBER_APPEND)
+pindex(CLOBBERAPPEND)
+pindex(NOCLOBBERAPPEND)
+cindex(clobbering, POSIX compatibility)
+cindex(file clobbering, POSIX compatibility)
+cindex(no clobber, POSIX compatible)
+item(tt(CLOBBER_APPEND) <K> <S>)(
+This option only applies when tt(NO_CLOBBER) (-tt(C)) is in effect.
+
+If this option is not set, the shell will report an error when a
+append redirection (tt(>>)) is used on a file that does not already
+exists. If the option is set, no error is reported.
+)
pindex(CONTINUE_ON_ERROR)
pindex(NO_CONTINUE_ON_ERROR)
pindex(CONTINUEONERROR)
diff --git a/Src/exec.c b/Src/exec.c
index 50a11eb..4ddfdf4 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -3315,7 +3315,8 @@ execcmd(Estate state, int input, int output, int how, int last1)
fil = -1;
else if (IS_APPEND_REDIR(fn->type))
fil = open(unmeta(fn->name),
- (unset(CLOBBER) && !IS_CLOBBER_REDIR(fn->type)) ?
+ ((unset(CLOBBER) || isset(CLOBBERAPPEND)) &&
+ !IS_CLOBBER_REDIR(fn->type)) ?
O_WRONLY | O_APPEND | O_NOCTTY :
O_WRONLY | O_APPEND | O_CREAT | O_NOCTTY, 0666);
else
diff --git a/Src/options.c b/Src/options.c
index da3d830..3a0c838 100644
--- a/Src/options.c
+++ b/Src/options.c
@@ -110,6 +110,7 @@ static struct optname optns[] = {
{{NULL, "chaselinks", OPT_EMULATE}, CHASELINKS},
{{NULL, "checkjobs", OPT_EMULATE|OPT_ZSH}, CHECKJOBS},
{{NULL, "clobber", OPT_EMULATE|OPT_ALL}, CLOBBER},
+{{NULL, "clobberappend", OPT_EMULATE|OPT_BOURNE}, CLOBBER},
{{NULL, "combiningchars", 0}, COMBININGCHARS},
{{NULL, "completealiases", 0}, COMPLETEALIASES},
{{NULL, "completeinword", 0}, COMPLETEINWORD},
diff --git a/Src/zsh.h b/Src/zsh.h
index ce9b979..05efa5f 100644
--- a/Src/zsh.h
+++ b/Src/zsh.h
@@ -2120,6 +2120,7 @@ enum {
CHASELINKS,
CHECKJOBS,
CLOBBER,
+ CLOBBERAPPEND,
COMBININGCHARS,
COMPLETEALIASES,
COMPLETEINWORD,
next prev parent reply other threads:[~2015-06-27 17:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 1:02 Martijn Dekker
2015-06-25 1:49 ` Bart Schaefer
2015-06-25 2:22 ` Martijn Dekker
2015-06-25 7:30 ` Bart Schaefer
2015-06-25 14:04 ` Stephane Chazelas
2015-06-25 16:00 ` Bart Schaefer
2015-06-25 19:20 ` Chet Ramey
2015-06-26 14:14 ` Martijn Dekker
2015-06-26 20:15 ` Bart Schaefer
2015-06-27 1:54 ` Martijn Dekker
2015-06-27 3:38 ` Bart Schaefer
2015-06-27 17:02 ` Peter Stephenson [this message]
2015-06-28 0:02 ` Martijn Dekker
2015-06-28 0:46 ` Martijn Dekker
2015-06-28 7:48 ` Stephane Chazelas
2015-06-28 9:15 ` Oliver Kiddle
2015-06-28 14:00 ` Stephane Chazelas
2015-06-28 18:38 ` Bart Schaefer
2015-06-28 19:30 ` Stephane Chazelas
2015-07-23 2:56 ` PATCH: sysopen (was Re: '>>' does not create file if set -C (noclobber) is active) Oliver Kiddle
2015-07-24 10:57 ` Peter Stephenson
2015-07-24 11:55 ` Peter Stephenson
2015-07-30 11:05 ` Mikael Magnusson
2015-07-31 12:41 ` Oliver Kiddle
2015-07-31 14:02 ` Mikael Magnusson
2015-06-28 17:19 ` '>>' does not create file if set -C (noclobber) is active Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150627180230.5fda7e09@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).