From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: Strange regression in zsh-git with redirecting output of 'readonly'
Date: Sat, 27 Jun 2015 23:55:08 +0100 [thread overview]
Message-ID: <20150627235508.7d0d6b40@ntlworld.com> (raw)
In-Reply-To: <558F2167.5080902@inlv.org>
On Sun, 28 Jun 2015 00:19:19 +0200
Martijn Dekker <martijn@inlv.org> wrote:
> There's a regression in current zsh git version: attempting to
> redirecting the output of a "readonly" with assignment argument (i.e. a
> potential error message) causes at least three kinds of different and
> unpredictable strange behaviour. But in all three cases, the command
> fails to work. In zsh 5.0.8 and earlier, all this works fine.
Does this fix it?
diff --git a/Src/parse.c b/Src/parse.c
index 477f8a0..09567fd 100644
--- a/Src/parse.c
+++ b/Src/parse.c
@@ -1868,6 +1868,8 @@ par_simple(int *cmplx, int nr)
*cmplx = c = 1;
nrediradd = par_redir(&r, NULL);
p += nrediradd;
+ if (ppost)
+ ppost += nrediradd;
sr += nrediradd;
} else if (tok == ENVSTRING) {
char *ptr, *name, *str;
pws
next prev parent reply other threads:[~2015-06-27 22:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 22:19 Martijn Dekker
2015-06-27 22:45 ` Bart Schaefer
2015-06-27 22:55 ` Martijn Dekker
2015-06-27 22:55 ` Peter Stephenson [this message]
2015-06-27 23:08 ` Martijn Dekker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150627235508.7d0d6b40@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).