From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19511 invoked by alias); 8 Jul 2015 10:49:19 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35730 Received: (qmail 765 invoked from network); 8 Jul 2015 10:49:17 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.0 X-AuditID: cbfec7f5-f794b6d000001495-7c-559cfdcd8cb2 Date: Wed, 08 Jul 2015 11:39:01 +0100 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: PATCH: Make ztrftime pass more things to strftime Message-id: <20150708113901.5ea7fd86@pwslap01u.europe.root.pri> In-reply-to: <1436310900-9519-1-git-send-email-mikachu@gmail.com> References: <1436310900-9519-1-git-send-email-mikachu@gmail.com> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrELMWRmVeSWpSXmKPExsVy+t/xK7pn/84JNbh2j8viYPNDJgdGj1UH PzAFMEZx2aSk5mSWpRbp2yVwZWw/tpepoJ+tonNTTgPjF5YuRk4OCQETicmvj0LZYhIX7q1n 62Lk4hASWMoo8ajlHjuEM4NJomnGamYIZyujxJJtm4AyHBwsAqoS5/YYgnSzCRhKTN00mxHE FhEQlzi79jzYVGEBO4kjFzuZQWxeAXuJPU/6wGo4BRwlWo9uZAWxhQQcJN7d288GYvML6Etc /fuJCeIie4mZV84wQvQKSvyYfA9sJrOAlsTmbU2sELa8xOY1b5kh5qhL3Li7m30Co9AsJC2z kLTMQtKygJF5FaNoamlyQXFSeq6RXnFibnFpXrpecn7uJkZIyH7dwbj0mNUhRgEORiUeXo+Y OaFCrIllxZW5hxglOJiVRHh3XQAK8aYkVlalFuXHF5XmpBYfYpTmYFES5525632IkEB6Yklq dmpqQWoRTJaJg1OqgXHy43rXlZuvRH8R3a6kde2H2oZa/2XKT82O6AuYsu371xi2/9aZC/0c W5uCv63PbtinPK8htfbmzeqvUeFBUx0CRPaWFm+eHPd7j4C1BFvXY7Z3Qet3Cxy9t/hH6KSu hDzdrZ8jpeRlppgrMweeOvLCdbrXfdUJ5tzT9mz+5TdVp1hnvvKvoypKLMUZiYZazEXFiQCS oedkVQIAAA== On Wed, 8 Jul 2015 01:15:00 +0200 Mikael Magnusson wrote: > I poked at this for an hour, and this is the first version that passes > make check and doesn't segfault randomly, so it is not very well tested, > to say the least. Opinions on the approach? "Not totally doomed" (I haven't done a character-by-character survey of the goings on). Implementing on top of an interface like this is a real pain, since you can't help re-implementing chunks and scratching your head about how to pass the info you've got out back in again. But it's worth doing now internationalisation / internationalization / Internationalisierung / ... is considered basic. It probably mostly needs a few tests. print -P %D{...} will do most of what you want. pws