From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: Undo is also confused with narrow-to-region
Date: Thu, 9 Jul 2015 19:32:55 +0100 [thread overview]
Message-ID: <20150709193255.31e8e4da@ntlworld.com> (raw)
In-Reply-To: <17928.1436367453@thecus.kiddle.eu>
On Wed, 08 Jul 2015 16:57:33 +0200
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Peter wrote:
> >
> > The example I've given shows an explicit save and restore. It should
> > also be possible to use the double function scope trick, though I didn't
> > actually try.
> >
> > I haven't imposed any arbitrary limits on the value in UNDO_LIMIT_NO as,
> > on thinking about it, it seemed to create hostages to fortune for no
> > obvious gain.
>
> Thanks. Trying to apply this in read-from-minibuffer, I found that it
> was necessary to add a split-undo in after the BUFFER etc were setup,
> otherwise it was possible to do one initial undo. Also, I wonder if the
> if condition should do a return 1 rather than break so that it beeps -
> consistently with an undo that has reached the very first change. Or is
> the setlastline() call needed?
Finally committed. I don't see that you'd need setlastline() if you
tried a single undo interactively and it failed, so it ought to be OK to
return 1.
pws
next prev parent reply other threads:[~2015-07-09 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 15:26 Oliver Kiddle
2015-07-03 18:12 ` Mikael Magnusson
2015-07-06 8:39 ` Peter Stephenson
2015-07-06 11:46 ` Oliver Kiddle
2015-07-06 19:25 ` Peter Stephenson
2015-07-08 14:57 ` Oliver Kiddle
2015-07-09 18:32 ` Peter Stephenson [this message]
2015-07-10 9:34 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709193255.31e8e4da@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).