From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: Undo is also confused with narrow-to-region
Date: Fri, 10 Jul 2015 10:34:36 +0100 [thread overview]
Message-ID: <20150710103436.1f51f3fb@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <17928.1436367453@thecus.kiddle.eu>
On Wed, 8 Jul 2015 16:57:33 +0200
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> > UNDO_LIMIT_NO
>
> Thanks. Trying to apply this in read-from-minibuffer, I found that it
> was necessary to add a split-undo in after the BUFFER etc were setup,
> otherwise it was possible to do one initial undo.
Coming back to this after the last commit... perhaps recursive-edit
should start a new undo anyway? You'd have thought it was somewhat
illogical to turn up in the middle of an edit. (You might have thought
it was logical to force an undo limit at that point, too. Could be
options.) However, I suppose you now have full control, so it doesn't
matter so much.
Also, there's an inconsistency with the variable name here...
> -integer changeno=$UNDO_CHANGE_NO
> +integer savelim=$UNDO_LIMIT_NO changeno=$UNDO_CHANGE_NO
>...
> + UNDO_LIMIT_NO=save_limit
pws
prev parent reply other threads:[~2015-07-10 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 15:26 Oliver Kiddle
2015-07-03 18:12 ` Mikael Magnusson
2015-07-06 8:39 ` Peter Stephenson
2015-07-06 11:46 ` Oliver Kiddle
2015-07-06 19:25 ` Peter Stephenson
2015-07-08 14:57 ` Oliver Kiddle
2015-07-09 18:32 ` Peter Stephenson
2015-07-10 9:34 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710103436.1f51f3fb@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).