From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36126-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 29398 invoked by alias); 12 Aug 2015 14:45:51 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36126
Received: (qmail 28665 invoked from network); 12 Aug 2015 14:45:49 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham
	autolearn_force=no version=3.4.0
X-AuditID: cbfec7f5-f794b6d000001495-de-55cb5c199db0
Date: Wed, 12 Aug 2015 15:45:30 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: get-line shouldn't set histline
Message-id: <20150812154530.5a31223c@pwslap01u.europe.root.pri>
In-reply-to: <3787.1439389607@thecus.kiddle.eu>
References: <3787.1439389607@thecus.kiddle.eu>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsVy+t/xq7qSMadDDZ6dkbM42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGT9nLGcr+MxasXqFQwPjTZYuRk4OCQETiX9f7jFC2GISF+6t
	Z+ti5OIQEljKKDG18z4rhDODSeL12XnMEM42RolHn3Ywg7SwCKhKvFn7FaydTcBQYuqm2WC2
	CFB8zolTrCC2sICxxLb3X5hAbF4Be4lbKzeDxTkF9CWWrPjKDmILCehJPD50CayXHyh+9e8n
	JoiT7CVmXjnDCNErKPFj8j2ws5kFtCQ2b2tihbDlJTavecsMMUdd4sbd3ewTGIVmIWmZhaRl
	FpKWBYzMqxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFCgvbrDsalx6wOMQpwMCrx8N7oOxUq
	xJpYVlyZe4hRgoNZSYS3LuR0qBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeWpGan
	phakFsFkmTg4pRoYOcPrlvicefNX/rZkR/Th2WI/mT7dTzgerNecl5XQwiVYsP5h5x5r3+kX
	LDQ+p+m0Pf2oeLfmZ3+js2/nDa/cyZUzvaprg5K/9MQ87XttuJXvguazjT1xTQw54TvUVhlM
	PfKNeccbI4bN/ApnPsnMFomOnp5U9/240MF9AvobFicdWS7w85mnEktxRqKhFnNRcSIAtTgu
	d1YCAAA=

On Wed, 12 Aug 2015 16:26:47 +0200
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> The get-line widget is
> meant to insert the line from the buffer stack into the current line.
> Changing histline without setting the line to correspond to the text
> stored for the history entry results in undo information that doesn't
> make sense.

Yes, I think this is just because the code was copied from the case
where the line is being set when the line editor starts.  In that case
popping the line gives you the history context around where you pushed
it.  get-line seems like it should just grab the string and keep the
current context.  But most of the times I use get-line it doesn't
actually matter, so I can't swear this is always right.

pws