From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36156-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 13447 invoked by alias); 13 Aug 2015 23:28:16 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36156
Received: (qmail 28331 invoked from network); 13 Aug 2015 23:28:15 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW autolearn=ham autolearn_force=no
	version=3.4.0
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=mesmtp; bh=8fNJZZiREeGG/xRQPWwPZDt2DGw=; b=U7IzDp
	CazKypgRk0nEDS/y8UdZ3c+Kl1avKeV72bFJebLWGYXI4aLXaB3GD/J9lDUsjtu4
	EhoWPfL02zHLF8M0z0Gwk6+M1qi5dVtBn/+UUezkV28UqJW++h+xk9vOjmdpZNVj
	cTOCOAB/2clerjqKHvVxtSmv9vCh1+fmxE07Y=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=smtpout; bh=8fNJZZiREeGG/xRQPWwPZDt2DGw=; b=UKaXS
	Dq+dg2ibsLA4L7oDzCkpwNwpROsenuaVLcxh9EuQEIoeiuudoMEyDl7r4iBU8ci1
	3vJW4VbU3EGHxmaKB1FhBCFwIz2GpVr37XxoVN9oHtytmLHdrYvmgOp/fWV5qCKU
	jXxnlbO9jqRRlWEABNaFTtF/6vxCoEKME6ZCs8=
X-Sasl-enc: iXQl6OOifqrZTLidCQuvS0/7oWqfXOC+6Cmh87gEtEGl 1439507924
Date: Thu, 13 Aug 2015 23:18:42 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Wieland Hoffmann <themineo@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] _git: Quote the return value of
 __git_committish_range{first,last}
Message-ID: <20150813231842.GD1998@tarsus.local2>
References: <1439372177-32218-1-git-send-email-themineo@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1439372177-32218-1-git-send-email-themineo@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

Wieland Hoffmann wrote on Wed, Aug 12, 2015 at 11:36:17 +0200:
> Otherwise, __git_is_committish_range performs word splitting if it's
> passed a range that includes spaces (like "master@{1 week ago}..master").
...
> -  local first=$(__git_committish_range_first $1)
> -  local last=$(__git_committish_range_last $1)
> +  local first="$(__git_committish_range_first $1)"
> +  local last="$(__git_committish_range_last $1)"

I see this has been applied, but for future reference, note that it is
only necessary for 5.0.8 and older, since in zsh from git 'local' is
a reserved word and
    local x=$(echo foo bar)
doesn't perform word splitting.

Cheers,

Daniel