From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36206-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 10340 invoked by alias); 17 Aug 2015 22:00:41 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36206
Received: (qmail 29160 invoked from network); 17 Aug 2015 22:00:41 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=PxZLIhjUIsZGQreO
	Zv/rd4hgBlU=; b=3BUvcgJi8cVPOZB1GiGuZethVRk8p1R3qdTlAlK7kpw85VZz
	NQvk3J16riD/iBGkUXVPwTUYjgogue5uEpnFSGwUjXsHYORy9xikTfEZMLqynA0x
	g/HhCXHrXuHYrgGXL2IATADoEDiYzNk7uqlIEwvEHwfagpFAooCe2J4l10Y=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=PxZLIhjUIsZGQre
	OZv/rd4hgBlU=; b=eNRIvzcGG30cWByDHFE7Gb0lSOMRO3HUS8uTgoueDdznKWR
	FgRYuBxIjxoGSZoB6YgLTXYbg6dSR4bbtGpOotSfGRLKzd/SgCuFGRQ/whLef2XK
	dL/yrC6xmQHo1UM7TL6UxrO2e0vIy6nIUdKdvddmu2r2ZccqUg4patRbYysM=
X-Sasl-enc: UQlImUg3n4rKa1SLhC6ru+qSH6diXyNwq6O8h+1S+TsD 1439848838
Date: Mon, 17 Aug 2015 22:00:36 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: zsh-workers@zsh.org
Subject: Re: PRINT_EXIT_VALUE: Suppress for if/while conditions
Message-ID: <20150817220036.GB2283@tarsus.local2>
References: <20150731231225.GB2054@tarsus.local2>
 <20150813093238.046a1b08@pwslap01u.europe.root.pri>
 <20150813232020.GF1998@tarsus.local2>
 <20150814091945.2b048787@pwslap01u.europe.root.pri>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150814091945.2b048787@pwslap01u.europe.root.pri>
User-Agent: Mutt/1.5.21 (2010-09-15)

Peter Stephenson wrote on Fri, Aug 14, 2015 at 09:19:45 +0100:
> On Thu, 13 Aug 2015 23:20:20 +0000
> Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > I have no problem with ruling out the jobs/bg/fg callsites, as you
> > propose.  However, checking (synch == 1) would also mean the value of
> > PRINTEXITVALUE is entirely ignored when printjob() is called
> > asynchronously.  I can see that that is fine for jobs that don't have
> > STAT_NOPRINT set.¹  Is it also correct to ignore PRINTEXITVALUE in the
> > case (synch == 0 && (jn->stat & STAT_NOPRINT))?
> 
> My point is really that you don't want to *modify* the code unless synch
> == 1.  So sync == anything else should continue to do just what it does
> at the moment, but if synch == 1 you can apply your extra check.  That
> seems likely to do the nearest to what everybody wants.

I'll give that a shot.  (Was a bit busy so haven't coded it yet.)
Thanks again.