From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5047 invoked by alias); 17 Aug 2015 22:02:26 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36207 Received: (qmail 16972 invoked from network); 17 Aug 2015 22:02:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=3u79wBXXazVEP3EFjnBkOBnyyhI=; b=S3dxdk 1aoh1onT4/HXPcMh6M5H5NllcZMlRj3BffdFo8YmnaV4TvPvN6Lc9CGwwX/+8uGt hzLoFa7QlzhQE0kCOR12VUIVjTXeu27evxK6GuJGvYzI1RBcbkXijl22VIvi4lVk +MQv9ue8JU5ZYA3vBtPfcpAisbi/wRLZnRUB0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=3u79wBXXazVEP3EFjnBkOBnyyhI=; b=NMV8d /oVZn+vYlMxxHYvsnyT3T6KdLqSD+NzFOZCgOWBU6+La5FWC8fJgnTDsr+leMmcG q/WGUoCoCFXlQZ9XyhJwtU7rXPU6RVQODnYMhdLWAVgISXctKCszkxASjj/1XsOQ wizUhPnipzS/590mSQhujnBJ5EHzGu1/i/auqs= X-Sasl-enc: hqdI+zJE8gziiEO8+lull9fJU+QVnnqqsN39L61RMuU9 1439848943 Date: Mon, 17 Aug 2015 22:02:21 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: incorrect setopt completion Message-ID: <20150817220221.GC2283@tarsus.local2> References: <20150815000543.GA2043@zira.vinc17.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Mikael Magnusson wrote on Sat, Aug 15, 2015 at 03:02:45 +0200: > If anyone is very bored, they could make a separate variable that gets > checked instead of / in addition to isset(PRINTEXITVALUE) in relevant > places, and leave the value of the option alone, but for now I'll just > do this. I think my PRINT_EXIT_VALUE branch (discussed in another thread) does this: https://github.com/danielshahaf/zsh/commit/ba8c0a1afd5c000cbb86aa988e85bd8ba7cf99ff > -onopts=( ${(k)_comp_caller_options[(R)on]} ) > +onopts=( ${(k)_comp_caller_options[(R)on]} printexitvalue ) I suggest a comment explaining why printexitvalue is special-cased. (So people don't have to run 'git blame' and then search the list archives.)