zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: UNDO_LIMIT_NO and its documentation
Date: Tue, 18 Aug 2015 10:17:34 +0100	[thread overview]
Message-ID: <20150818101734.2a0ea7e9@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20150818092643.1aa9ce9b@pwslap01u.europe.root.pri>

On Tue, 18 Aug 2015 09:26:43 +0100
Peter Stephenson <p.stephenson@samsung.com> wrote:
> > Firstly, why not just
> > 
> > 	local UNDO_LIMIT_NO=$UNDO_CHANGE_NO
> > 
> > and allow function scoping to restore it?
> 
> As noted in the comments when the patch appeared, you'd need double
> function scope because of the way ZLE widgets work.  I couldn't be
> bothered to explain, but surrounding the code with (){ ... } should be
> OK in principle.

I think this works.

pws

diff --git a/Doc/Zsh/zle.yo b/Doc/Zsh/zle.yo
index 697b636..c06e226 100644
--- a/Doc/Zsh/zle.yo
+++ b/Doc/Zsh/zle.yo
@@ -971,14 +971,12 @@ to use `tt(zle undo) var(change)' in a widget to undo beyond
 that point; in that case, it will not be possible to undo at
 all until tt(UNDO_LIMIT_NO) is reduced.  Set to 0 to disable the limit.
 
-A typical use of this variable in a widget function is as follows:
+A typical use of this variable in a widget function is as follows (note
+the additional function scope is required):
 
-example(integer save_limit=$UNDO_LIMIT_NO
-UNDO_LIMIT_NO=$UNDO_CHANGE_NO
-{
+example(LPAR()RPAR() {
+  local UNDO_LIMIT_NO=$UNDO_CHANGE_NO
   # Perform some form of recursive edit.
-} always {
-  UNDO_LIMIT_NO=save_limit
 })
 )
 vindex(WIDGET)


      reply	other threads:[~2015-08-18  9:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18  7:09 Bart Schaefer
2015-08-18  8:26 ` Peter Stephenson
2015-08-18  9:17   ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150818101734.2a0ea7e9@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).