From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13402 invoked by alias); 27 Aug 2015 13:47:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36291 Received: (qmail 14791 invoked from network); 27 Aug 2015 13:47:35 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Date: Thu, 27 Aug 2015 15:47:29 +0200 From: Axel Beckert To: zsh-workers@zsh.org Subject: Re: Testsuite failures in A05execution inside Jenkins, but not locally (was: zsh 5.0.8.-test-3) Message-ID: <20150827134728.GV9970@sym.noone.org> Mail-Followup-To: zsh-workers@zsh.org References: <20150825194807.194b3bed@ntlworld.com> <20150826135819.GO9970@sym.noone.org> <150826110702.ZM23706@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150826110702.ZM23706@torch.brasslantern.com> X-Operating-System: Linux 3.2.0-4-amd64 X-Machine: sym2 x86_64 X-Editor: GNU Emacs 23.4.1 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAAAAAC3mUtaAAAABGdBTUEAALGPC/xhBQAAADh0RVh0U29mdHdhcmUAWFYgVmVyc2lvbiAzLjEwYSAgUmV2OiAxMi8yOS85NCAoUE5HIHBhdGNoIDEuMindFS5JAAACGElEQVQ4jXXQMU8UYRDG8f8shNjdDH4AbpfGDjAWlKiJiZ0ajL1aGCvsNCbGaCGG1koLaztaTYz6ATy+gOyehYmF3MxVxgg3FnDsHcTpJr/M+8w7Rf6nCsaVTTDqxbg9hoOXmw83H71+Eyfg4E1d7/Z2fG9rGkZbTQiu+K+3U/C+76lmkvAhJuDndnoAiftou4V84okAGclop4U/jYACZDTxrYWP0gkxVfAm/W//GLZpxIzwIN0Hn8dw0B+IWkZmQmRsj2HfhwokEklHfNCCiQCRgAR7YyhQVRVTCKCzP4Y5zBBE0t0zY3Q8oQaBqqAMlVEcgVQd9706zGirAFium8HXumlMIeMwqQCInju+2+uB6MRENupdpMt8pRlHZyuAW0F+Mb6XSIVqtxjD+iVmVqqystLEzFTGT92YqRaXpNT5eTVjeJhbALPnrTxLUZUKZsgxcNm64hAOYisT/xhF+oKTGU5RegtC3Rt6eEDi/QnIevdTx9Md2EMmYBRmCQR1026FCGQQJJExsRUqgkMGaWSbwYLnoO4T6VgpbQbdELPMBAHWWrhYrcxXnYgAsatPWygkFCBD4K62MAsOTqA6szYRPpsu6e6Y8mPiVrBMNuGIMrgwBUu4p2DgG1Ownu6hpuTv7hScefHAzAC/yRRw5U5pALMbJ4AUALvHSZhxgHPXTsHcdWD1GadAHr9avP+c0wCr7263Df8ASLwXWHWs+KIAAAAHdElNRQfYBQEBODPr Organization: DeuxChevaux.org -- The =?iso-8859-1?Q?Citr?= =?iso-8859-1?B?b+tu?= 2CV Database User-Agent: Mutt/1.5.21 (2010-09-15) Hi, On Wed, Aug 26, 2015 at 11:07:02AM -0700, Bart Schaefer wrote: > } + (eval):printf:4: write error: broken pipe > } + (eval):4: write error: inappropriate ioctl for device > } + cat: write error: Broken pipe > } + hang:printf: write error: broken pipe > } + hang: write error: inappropriate ioctl for device > } Was testing: Bug regression: piping a shell construct to an external process may hang > > Those broken pipe errors are irrelevant to the test (in fact they're the > expected reason for the printf and cat processes to terminate, but under > normal circumstances that doesn't print an error). So I think we can > safely throw them away. > > Consequently, does this fix it? Not fully, maybe we need more "2>/dev/null"? Current failure: Running test: Bug regression: piping a shell construct to an external process may hang This test takes 5 seconds to fail... *** /tmp/zsh.ztst.err.6382 Wed Aug 26 21:24:06 2015 --- /tmp/zsh.ztst.terr.6382 Wed Aug 26 21:24:06 2015 *************** *** 0 **** --- 1,2 ---- + (eval):printf:4: write error: broken pipe + (eval):4: write error: inappropriate ioctl for device Test ../../Test/A05execution.ztst failed: error output differs from expected as shown above for: { unsetopt MONITOR } 2>/dev/null coproc { read -et 5 || { print -u $ZTST_fd KILLED; kill -HUP -$$ } } print -u $ZTST_fd 'This test takes 5 seconds to fail...' { printf "%d\n" {1..20000} } | ( read -e ) hang(){ printf "%d\n" {2..20000} | cat }; hang 2>/dev/null | ( read -e ) sleep 1 ;: avoid coproc exit race condition print -p done read -et 6 -p Was testing: Bug regression: piping a shell construct to an external process may hang ../../Test/A05execution.ztst: test failed. The following may (or may not) help identifying the cause: This test checks for a file descriptor leak that could cause the left side of a pipe to block on write after the right side has exited Maybe this line needs a "2>/dev/null", too? > { printf "%d\n" {1..20000} } | ( read -e ) Will try that. Kind regards, Axel -- /~\ Plain Text Ribbon Campaign | Axel Beckert \ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail) X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber) / \ I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)