From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: invalid characters and multi-byte [x-y] ranges
Date: Fri, 04 Sep 2015 13:35:42 +0100 [thread overview]
Message-ID: <20150904133542.4673f880@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20150904124719.36ad9457@pwslap01u.europe.root.pri>
On Fri, 4 Sep 2015 12:47:19 +0100
Peter Stephenson <p.stephenson@samsung.com> wrote:
> On Fri, 4 Sep 2015 10:53:14 +0000
> Ismail Donmez <ismail@i10z.com> wrote:
> on <p.stephenson <at> samsung.com> writes:
> > This seems to break glob tests:
>
> I missed that --- it looks like there's something funny with the (#i)
> flag. That may mean there's a pre-existing funny since it shouldn't be
> encountering anything looking like invalid characters.
It was just stupidity. I changed a line that referred to an ASCII
character rather than an invalid multibyte character.
> Looks like the alias test needs updating for the new report format
> (presumably trivial).
It waqs just stupidity. I hadn't recompiled after pulling that change.
Can't get the staff.
pws
diff --git a/Src/pattern.c b/Src/pattern.c
index 7457cbd..b4ba33e 100644
--- a/Src/pattern.c
+++ b/Src/pattern.c
@@ -1929,7 +1929,7 @@ charrefinc(char **x, char *y, int *z)
size_t ret;
if (!(patglobflags & GF_MULTIBYTE) || !(STOUC(**x) & 0x80))
- return WCHAR_INVALID(*(*x)++);
+ return (wchar_t) STOUC(*(*x)++);
ret = mbrtowc(&wc, *x, y-*x, &shiftstate);
next prev parent reply other threads:[~2015-09-04 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 23:07 Stephane Chazelas
2015-09-03 9:00 ` Peter Stephenson
2015-09-03 10:09 ` Stephane Chazelas
2015-09-03 14:18 ` Peter Stephenson
2015-09-04 10:53 ` Ismail Donmez
2015-09-04 11:47 ` Peter Stephenson
2015-09-04 12:35 ` Peter Stephenson [this message]
2015-09-04 15:02 ` Ismail Donmez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904133542.4673f880@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).