From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36460-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 27642 invoked by alias); 9 Sep 2015 14:39:13 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36460
Received: (qmail 12511 invoked from network); 9 Sep 2015 14:39:12 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.0
X-AuditID: cbfec7f5-f794b6d000001495-c6-55f044891073
Date: Wed, 09 Sep 2015 15:39:02 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Multiple as-installed test suite failures under different
 circumstances with 5.1-test-1
Message-id: <20150909153902.06cfe911@pwslap01u.europe.root.pri>
In-reply-to: <20150909141027.GI3721@sym.noone.org>
References: <20150908213644.GD3721@sym.noone.org>
 <CAH+w=7ZsMY4HSv-sPbLQj5U-yqRf3+-MAR63jdrtD=7HcF4AfQ@mail.gmail.com>
 <20150909092758.261695e2@pwslap01u.europe.root.pri>
 <20150909110403.GH3721@sym.noone.org> <20150909141027.GI3721@sym.noone.org>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t/xa7qdLh9CDWZdZ7E42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGdtu3GUumMFZsXLNBrYGxpnsXYycHBICJhIXXnewQNhiEhfu
	rWfrYuTiEBJYyihxuvM8E4Qzg0li3r79UM5WRonlO8+AtbAIqErc/N/ABmKzCRhKTN00mxHE
	FhEQlzi79jxYjbBAmsT9U7fA4rwC9hL3r/aDxTkFjCQaz8wGs4UE/jBKrL2eBGLzC+hLXP37
	iQniJHuJmVfOQPUKSvyYfA+snllAS2LztiZWCFteYvOat8wQc9QlbtzdzT6BUWgWkpZZSFpm
	IWlZwMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMkbL/uYFx6zOoQowAHoxIP74SW96FC
	rIllxZW5hxglOJiVRHhTrD+ECvGmJFZWpRblxxeV5qQWH2KU5mBREueduet9iJBAemJJanZq
	akFqEUyWiYNTqoFxw8njTtZt9x6I7dsifHDV+r+/bn6bOGnxu10Xr1tpBQmEl0p/+tflscvj
	mfq1tfdYLqQkMUSIxKxKfxKcmf9Kc2VuvMUy4/ovh3onctS9rrp0xu58eOv+ZTNVLCZPaY6O
	dazU2PjiH/vf3KNFaSYpGY7NFwJEv/sxKizNcA61/lJ7c8H6CzXhSizFGYmGWsxFxYkA/eVx
	xVcCAAA=

On Wed, 9 Sep 2015 16:10:27 +0200
Axel Beckert <abe@deuxchevaux.org> wrote:
> We though had a test suite failure at _build_ time (i.e. "make test"
> directly after the build) once and only once withing 5 build runs so
> far, so it may be a kind of race condition:
> 
>...
> Test ../../Test/E01options.ztst failed: error output differs from expected as shown above for:
>...
> Was testing: SH_NULLCMD option
>...
> ../../Test/E01options.ztst: test failed.
> ../../Test/E02xtrace.ztst: starting.
> + fn:echo:2: write error: broken pipe
> + fn:2: write error: inappropriate ioctl for device
>...
> I wonder if that's another case of a missing "2>/dev/null" like we
> fixed a few before 5.1?

OK, I suppose

  echo hello | >foo

in the case of SH_NULLCMD, which is equivalent to

  echo hello | : >foo

is indeed liable to the race in question, which is entirely benign for
this test.  It shouldn't fail for the case where this is doing a cat,
but the stdout test output already checks we picked that up, so
suppressing the error looks reasonable.

How about changing it to

  { echo hello | >foo } 2>/dev/null

?  Is that good enough?

pws