From: Axel Beckert <abe@deuxchevaux.org>
To: zsh-workers@zsh.org
Subject: Re: Multiple as-installed test suite failures under different circumstances with 5.1-test-1
Date: Thu, 10 Sep 2015 09:31:01 +0200 [thread overview]
Message-ID: <20150910073100.GL3721@sym.noone.org> (raw)
In-Reply-To: <20150909153902.06cfe911@pwslap01u.europe.root.pri>
Hi Peter,
On Wed, Sep 09, 2015 at 03:39:02PM +0100, Peter Stephenson wrote:
> > ../../Test/E01options.ztst: test failed.
> > + fn:echo:2: write error: broken pipe
> > + fn:2: write error: inappropriate ioctl for device
> >...
> > I wonder if that's another case of a missing "2>/dev/null" like we
> > fixed a few before 5.1?
>
> OK, I suppose
>
> echo hello | >foo
>
> in the case of SH_NULLCMD, which is equivalent to
>
> echo hello | : >foo
>
> is indeed liable to the race in question, which is entirely benign for
> this test. It shouldn't fail for the case where this is doing a cat,
> but the stdout test output already checks we picked that up, so
> suppressing the error looks reasonable.
>
> How about changing it to
>
> { echo hello | >foo } 2>/dev/null
>
> ? Is that good enough?
Looks fine and the two builds I did since then worked fine, too. Then
again, I can't really say since we saw this only once so far and
couldn't reproduce since then.
I'm keeping this now in the Debian package as a patch for while unless
you think it's good enough to be committed upstream anyways.
Kind regards, Axel
--
/~\ Plain Text Ribbon Campaign | Axel Beckert
\ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail)
X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \ I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)
next prev parent reply other threads:[~2015-09-10 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 21:36 Axel Beckert
2015-09-08 23:05 ` Bart Schaefer
2015-09-09 8:27 ` Peter Stephenson
2015-09-09 11:04 ` Axel Beckert
2015-09-09 14:10 ` Axel Beckert
2015-09-09 14:39 ` Peter Stephenson
2015-09-10 7:31 ` Axel Beckert [this message]
2015-09-10 8:22 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910073100.GL3721@sym.noone.org \
--to=abe@deuxchevaux.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).