From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22270 invoked by alias); 10 Sep 2015 07:31:09 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36461 Received: (qmail 3262 invoked from network); 10 Sep 2015 07:31:06 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Date: Thu, 10 Sep 2015 09:31:01 +0200 From: Axel Beckert To: zsh-workers@zsh.org Subject: Re: Multiple as-installed test suite failures under different circumstances with 5.1-test-1 Message-ID: <20150910073100.GL3721@sym.noone.org> Mail-Followup-To: zsh-workers@zsh.org References: <20150908213644.GD3721@sym.noone.org> <20150909092758.261695e2@pwslap01u.europe.root.pri> <20150909110403.GH3721@sym.noone.org> <20150909141027.GI3721@sym.noone.org> <20150909153902.06cfe911@pwslap01u.europe.root.pri> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150909153902.06cfe911@pwslap01u.europe.root.pri> X-Operating-System: Linux 3.2.0-4-amd64 X-Machine: sym2 x86_64 X-Editor: GNU Emacs 23.4.1 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAAAAAC3mUtaAAAABGdBTUEAALGPC/xhBQAAADh0RVh0U29mdHdhcmUAWFYgVmVyc2lvbiAzLjEwYSAgUmV2OiAxMi8yOS85NCAoUE5HIHBhdGNoIDEuMindFS5JAAACGElEQVQ4jXXQMU8UYRDG8f8shNjdDH4AbpfGDjAWlKiJiZ0ajL1aGCvsNCbGaCGG1koLaztaTYz6ATy+gOyehYmF3MxVxgg3FnDsHcTpJr/M+8w7Rf6nCsaVTTDqxbg9hoOXmw83H71+Eyfg4E1d7/Z2fG9rGkZbTQiu+K+3U/C+76lmkvAhJuDndnoAiftou4V84okAGclop4U/jYACZDTxrYWP0gkxVfAm/W//GLZpxIzwIN0Hn8dw0B+IWkZmQmRsj2HfhwokEklHfNCCiQCRgAR7YyhQVRVTCKCzP4Y5zBBE0t0zY3Q8oQaBqqAMlVEcgVQd9706zGirAFium8HXumlMIeMwqQCInju+2+uB6MRENupdpMt8pRlHZyuAW0F+Mb6XSIVqtxjD+iVmVqqystLEzFTGT92YqRaXpNT5eTVjeJhbALPnrTxLUZUKZsgxcNm64hAOYisT/xhF+oKTGU5RegtC3Rt6eEDi/QnIevdTx9Md2EMmYBRmCQR1026FCGQQJJExsRUqgkMGaWSbwYLnoO4T6VgpbQbdELPMBAHWWrhYrcxXnYgAsatPWygkFCBD4K62MAsOTqA6szYRPpsu6e6Y8mPiVrBMNuGIMrgwBUu4p2DgG1Ownu6hpuTv7hScefHAzAC/yRRw5U5pALMbJ4AUALvHSZhxgHPXTsHcdWD1GadAHr9avP+c0wCr7263Df8ASLwXWHWs+KIAAAAHdElNRQfYBQEBODPr Organization: DeuxChevaux.org -- The =?iso-8859-1?Q?Citr?= =?iso-8859-1?B?b+tu?= 2CV Database User-Agent: Mutt/1.5.21 (2010-09-15) Hi Peter, On Wed, Sep 09, 2015 at 03:39:02PM +0100, Peter Stephenson wrote: > > ../../Test/E01options.ztst: test failed. > > + fn:echo:2: write error: broken pipe > > + fn:2: write error: inappropriate ioctl for device > >... > > I wonder if that's another case of a missing "2>/dev/null" like we > > fixed a few before 5.1? > > OK, I suppose > > echo hello | >foo > > in the case of SH_NULLCMD, which is equivalent to > > echo hello | : >foo > > is indeed liable to the race in question, which is entirely benign for > this test. It shouldn't fail for the case where this is doing a cat, > but the stdout test output already checks we picked that up, so > suppressing the error looks reasonable. > > How about changing it to > > { echo hello | >foo } 2>/dev/null > > ? Is that good enough? Looks fine and the two builds I did since then worked fine, too. Then again, I can't really say since we saw this only once so far and couldn't reproduce since then. I'm keeping this now in the Debian package as a patch for while unless you think it's good enough to be committed upstream anyways. Kind regards, Axel -- /~\ Plain Text Ribbon Campaign | Axel Beckert \ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail) X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber) / \ I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)