From: Axel Beckert <abe@deuxchevaux.org>
To: zsh-workers@zsh.org
Cc: thuejk@gmail.com
Subject: Fwd: [Bug 1495151] zsh completion for gphoto2 gives "--delete-files" instead of the correct "--delete-file"
Date: Sun, 13 Sep 2015 01:53:17 +0200 [thread overview]
Message-ID: <20150912235317.GM3721@sym.noone.org> (raw)
Hi,
I received the following bug report via Ubuntu's Launchpad:
----- Forwarded message from Thue Janus Kristensen <thuejk@gmail.com> -----
Date: Sat, 12 Sep 2015 21:34:14 -0000
From: Thue Janus Kristensen <thuejk@gmail.com>
Subject: [Bug 1495151] [NEW] zsh completion for gphoto2 gives "--delete-files" instead of the correct "--delete-file"
Reply-To: Bug 1495151 <1495151@bugs.launchpad.net>
[…]
Public bug reported:
Zsh tab completion for gphoto2 has incorrect tab completion for
"--delete-file", wrongly appending an "s".
The error comes from the file
/usr/share/zsh/functions/Completion/Unix/_gphoto2
with the line
'--delete-files[delete files given in range]:range' \
ProblemType: Bug
DistroRelease: Ubuntu 15.04
Package: zsh-common 5.0.7-5ubuntu1
[…]
https://bugs.launchpad.net/bugs/1495151
[…]
----- End forwarded message -----
I can confirm this by comparing "gphoto2 --help | fgrep delete" with
Completion/Unix/_gphoto2 in git.
Here's the according patch I'd commit:
diff --git a/Completion/Unix/Command/_gphoto2 b/Completion/Unix/Command/_gphoto2
index 95d8a49..314d83e 100644
--- a/Completion/Unix/Command/_gphoto2
+++ b/Completion/Unix/Command/_gphoto2
@@ -32,7 +32,7 @@ _arguments -s \
'--get-all-raw-data[get all raw data from folder]' \
'--get-audio-data[get audio data given in range]:range' \
'--get-all-audio-data[get all audio data from folder]' \
- '--delete-files[delete files given in range]:range' \
+ '--delete-file[delete files given in range]:range' \
'--delete-all-files[delete all files in folder]' \
'(-u --upload-file)'{-u,--upload-file}'[upload a file to camera]:file:_files' \
'--capture-preview[capture a quick preview]' \
Kind regards, Axel
--
/~\ Plain Text Ribbon Campaign | Axel Beckert
\ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail)
X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \ I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)
next reply other threads:[~2015-09-12 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 23:53 Axel Beckert [this message]
2015-09-13 0:18 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150912235317.GM3721@sym.noone.org \
--to=abe@deuxchevaux.org \
--cc=thuejk@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).