From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36583-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 7024 invoked by alias); 21 Sep 2015 20:34:12 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36583
Received: (qmail 29152 invoked from network); 21 Sep 2015 20:34:12 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=mail.ud10.udmedia.de; h=
	date:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=beta; bh=/CoiNZ8/BZGfE9SILEruFygUkT
	5DnIwsKPjHe9s5+s0=; b=JtjqxvhNg3L1WGqC44wQ3da8xEPn7SGm1UnIxaVJ6x
	HX+Br7iY9xKUGu5JpaORoyDqNcBPN/hW+/cKf15vfKBjERVal5Pbu50AWwSVZ2S+
	NZzKHWFmweYv4rnX/3GsFABi9UalywzF+e92qpx55tI26Zd9zwd/MrvhuX4bdZCK
	M=
Date: Mon, 21 Sep 2015 22:34:09 +0200
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org
Subject: Re: Two issues found with -fsanitize=undefined
Message-ID: <20150921203409.GB8913@x4>
References: <20150917075759.GA24365@x4>
 <20150921201306.0017146b@ntlworld.com>
 <20150921200413.GA8913@x4>
 <20150921212113.74706d86@ntlworld.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150921212113.74706d86@ntlworld.com>

On 2015.09.21 at 21:21 +0100, Peter Stephenson wrote:
> On Mon, 21 Sep 2015 22:04:13 +0200
> Markus Trippelsdorf <markus@trippelsdorf.de> wrote:
> > Yes:
> > matchbuflen: (null) with no matchbuf: 0
> > It looks like the issue doesn't happen with a -DDEBUG build.
> > I've changed the DPUTS line to:
> >  fprintf(stderr, "matchbuflen: %s with no matchbuf: %x", matchbuf, matchbuflen);
> 
> That's fine.  If matchbuf is NULL, matchbuflen *should* be 0.
> 
> I presume you're missing that
> 
>   DPUTS(matchbuflen, "matchbuflen with no matchbuf");
> 
> is (roughly) equivalent to
> 
>   if (matchbuflen)
>      fprintf(stderr, "matchbuflen with no matcbuf");

Well, only if DEBUG is defined. And as I wrote above the issue doesn't
happen at all for -DDEBUG.

-- 
Markus