From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36585-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 18291 invoked by alias); 21 Sep 2015 21:27:57 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36585
Received: (qmail 11176 invoked from network); 21 Sep 2015 21:27:54 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=mesmtp; bh=NBs9xy+JI6irMqrCWXf4M/xdgf8=; b=yIKMSC
	avgr9l9Q5oJePoewJ5pmik6WkLu/IwbbGVrWUWg+fTcLbkhXDvFDa5SLCX4EaXcZ
	IoaaI1JXwt+66nIpRWhqQEFji/idJI17Ac9ZMWTuiqrURxccvMQOC4FRSQx1Q5P3
	dxuV0/lEkvXRlzxzxV2Dh/JvB6wcvgoDGXtDs=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=smtpout; bh=NBs9xy+JI6irMqrCWXf4M/xdgf8=; b=i6zlv
	UUBueRf62jHIowQRFPEWWkFrs5wbX/rmkXChJynpsrwxmEn7ZTC2POnfhHZ7Nyq5
	7NDTKAewYWB6XRsGaTwraV3+RYHMyXGvPYtAu+KnMjFOK44ztqnoQsyxSuQOwWEY
	Sia83N5xMcat6K2eYICWwmBqVBPSXm8qUJIO/o=
X-Sasl-enc: njl5DqBVn86iC0BCplvWGImS+j6JdxCuBpTqFs655ANi 1442870205
Date: Mon, 21 Sep 2015 21:16:43 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Vasil <mailing_lists@petervasil.net>
Cc: zsh-workers@zsh.org
Subject: Re: edit-command-line problem with emacsclient
Message-ID: <20150921211643.GJ1955@tarsus.local2>
References: <55FE9C92.7030203@petervasil.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55FE9C92.7030203@petervasil.net>
User-Agent: Mutt/1.5.21 (2010-09-15)

Peter Vasil wrote on Sun, Sep 20, 2015 at 13:46:26 +0200:
> Commit 35ffe36318955d03fca3df0d34a0997970cfc6a3 introduced the change,
> that when calling edit-command-line, the curser is put to the right offset.
> 

I wrote that.  Sorry for the bug.  I'm a vim user, and I sanity-tested
the emacs case, but I don't actually speak emacs lisp, so I'm not
surprised the patch was complete but not sound.  I see now I forgot to
state in the patch mail that the emacs codepath needed extra review :-/

Cheers,

Daniel
(OT: Perhaps I should add "I don't speak emacs lisp" to https://people.apache.org/~danielsh/bilmiyorum/?)

> This is implemented for vim and emacs, however if I set my EDITOR or
> VISUAL to emacsclient, the *emacs* condition gets called which does not
> work for emacsclient. The arguments specidied for emacs work only for
> Emacs but not for emacsclient.
> 
> It would be great to change the condition *emacs* that it does not match
> emacsclient or add another condition for emacsclient with appropriate
> arguments.
> 
> Thanks and bests,
> Peter
>