From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Christoph Mathys <eraserix@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [patch] _hg: completion for 'hg bookmarks'
Date: Fri, 25 Sep 2015 23:18:50 +0000 [thread overview]
Message-ID: <20150925231850.GB2082@tarsus.local2> (raw)
In-Reply-To: <CALqGcGqGeQCYduM_0_omdoZksqxw+qfJP+1Fh425D4tpYqz58Q@mail.gmail.com>
Christoph Mathys wrote on Fri, Sep 25, 2015 at 09:14:46 +0200:
> On Thu, Sep 24, 2015 at 6:05 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > 2. --rev and --message need to become --rev= and --message= to allow
> > both '--rev ARG' and '--rev=ARG' (which both work).
>
> Fixed for --rev.
>
I meant to say --rename, not --message. I'll change --rename to
--rename= (they both work).
> thx,
> Christophq
Thanks for fixing all the issues. I've just noticed another one, which
I missed in my first review: _arguments should be called without the -w
flag. (I'm quoting the man page from 5.1.1 since it changed recently:)
-w In combination with -s, allow option stacking even if one
or more of the options take arguments. For example, if
-x takes an argument, with no -s, `-xy' is considered as
a single (unhandled) option; with -s, -xy is an option
with the argument `y'; with both -s and -w, -xy may be
the option -x and the option -y with arguments still to
come.
So I removed the -w and pushed the patch. Possible further improvements
are to remove the -w, and change --foo to --foo=, throughout the rest of
_hg. (You don't have to do this additional patch, but you're welcome to
if you want.)
Thanks for the patches, Christoph!
Daniel
next prev parent reply other threads:[~2015-09-25 23:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 14:23 Christoph Mathys
2015-09-24 16:05 ` Daniel Shahaf
2015-09-24 16:29 ` Bart Schaefer
2015-09-24 22:17 ` Daniel Shahaf
2015-09-25 7:14 ` Christoph Mathys
2015-09-25 23:18 ` Daniel Shahaf [this message]
2015-09-26 0:23 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925231850.GB2082@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=eraserix@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).