From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36633-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 2297 invoked by alias); 25 Sep 2015 23:29:39 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36633
Received: (qmail 4237 invoked from network); 25 Sep 2015 23:29:35 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=mesmtp; bh=8ZbY8sy1mL/UqwFGyGogXqwMzzc=; b=YklD4D
	X+E4Og+PQh8lWVFxpJKd2+gg2DYELdeQZ8e1pjRp4Tt8CsSEs/9T5t18ieINXxwy
	7nJ2N5qoq4G6ou5YGv0q6zjiCqIjUdkwCYCpYVINUIHxv2MgqnIY33Tf44J1wxS4
	8cORizVShQ6fpmqXtR6gdxvEZl1IhU9VXlg+M=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=smtpout; bh=8ZbY8sy1mL/UqwFGyGogXqwMzzc=; b=aFabU
	JfOfuJKgWkkYP22taZxZy4IpL4PCldIXyrhjGvBcWJmMKFnAPfDsnKV5Sl8/xJE7
	ytk+iH6tHViKl6L2aFqs03ex3suoMKAjsmcz7UwNK3QX0ibLMGdLuCNeXEAxVgj/
	Kw4a/w6BxYIGLLDN+WvpcitlpyvKPtWLpY8i+0=
X-Sasl-enc: f4BfPDH5mS3rIzrWFDlof/Bv3F5gRITaw0ezsj3u7gaJ 1443223132
Date: Fri, 25 Sep 2015 23:18:50 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Christoph Mathys <eraserix@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [patch] _hg: completion for 'hg bookmarks'
Message-ID: <20150925231850.GB2082@tarsus.local2>
References: <CALqGcGrNrnNUQim4QbvhGyy+9h07JNBg3ixOzZiZ4JKUR5jVMg@mail.gmail.com>
 <20150924160550.GD1906@tarsus.local2>
 <CALqGcGqGeQCYduM_0_omdoZksqxw+qfJP+1Fh425D4tpYqz58Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALqGcGqGeQCYduM_0_omdoZksqxw+qfJP+1Fh425D4tpYqz58Q@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

Christoph Mathys wrote on Fri, Sep 25, 2015 at 09:14:46 +0200:
> On Thu, Sep 24, 2015 at 6:05 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > 2. --rev and --message need to become --rev= and --message= to allow
> > both '--rev ARG' and '--rev=ARG' (which both work).
> 
> Fixed for --rev.
> 

I meant to say --rename, not --message.  I'll change --rename to
--rename= (they both work).

> thx,
> Christophq

Thanks for fixing all the issues.  I've just noticed another one, which
I missed in my first review: _arguments should be called without the -w
flag.  (I'm quoting the man page from 5.1.1 since it changed recently:)

              -w     In combination with -s, allow option stacking even if one
                     or more of the options take arguments.  For  example,  if
                     -x  takes an argument, with no -s, `-xy' is considered as
                     a single (unhandled) option; with -s, -xy  is  an  option
                     with  the  argument  `y'; with both -s and -w, -xy may be
                     the option -x and the option -y with arguments  still  to
                     come.

So I removed the -w and pushed the patch.  Possible further improvements
are to remove the -w, and change --foo to --foo=, throughout the rest of
_hg.  (You don't have to do this additional patch, but you're welcome to
if you want.)

Thanks for the patches, Christoph!

Daniel