zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: ${(z)} split of unmatched, doubled ((
Date: Mon, 28 Sep 2015 01:55:31 +0000	[thread overview]
Message-ID: <20150928015531.GF1879@tarsus.local2> (raw)
In-Reply-To: <150927175906.ZM20369@torch.brasslantern.com>

Bart Schaefer wrote on Sun, Sep 27, 2015 at 17:59:06 -0700:
> So perhaps this:
> 
> +++ b/Src/lex.c
> @@ -785,6 +785,8 @@ gettok(void)
>  		default:
> +		    if (lexflags & LEXFLAGS_ACTIVE)
> +			tokstr = dyncat("((", tokstr);
>  		    return LEXERR;

LGTM: I've tested it both manually and under zsh-syntax-highlighting,
and it's an improvement in both cases.

> 
> It might be prudent to also test that tokstr != NULL there, but I have
> not found a sample input where that occurs.

The failure mode when tokstr is NULL is calling strlen/strcpy on a NULL
argument, which is formally undefined behaviour and practically will
probably just segfault.  If we can't prove that tokstr is always
non-NULL, I would vote to test it for NULL before using it.  

Thanks,

Daniel


  reply	other threads:[~2015-09-28  1:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-27  1:23 Daniel Shahaf
2015-09-27 16:00 ` Bart Schaefer
2015-09-27 23:51   ` Daniel Shahaf
2015-09-28  0:59     ` Bart Schaefer
2015-09-28  1:55       ` Daniel Shahaf [this message]
2015-09-28  3:30         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150928015531.GF1879@tarsus.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).