From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Substitution ${...///} slows down when certain UTF character occurs
Date: Mon, 28 Sep 2015 09:51:42 +0100 [thread overview]
Message-ID: <20150928095142.385a33eb@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <150927091121.ZM25721@torch.brasslantern.com>
On Sun, 27 Sep 2015 09:11:21 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Still I think the biggest issue is that unmetafication happening too
> low down. Since pattry*() is being called repeatedly with the same two
> first arguments (prog and string) it might be possible to cache the
> unmetafied string after the first call.
It would be good to optimise the cases where the calling code in glob.c
(for the parameter-style operators only) matches at different places along
the string, too, which means unmetafying at a higher level. That's
quite a lot of work in the glob.c code, though, because we'll need to
deal with length and switch the multibyte handlers to umetafied.
I think a reasonable strategy would be to change the call sequence for
pattrylen() and pattryrefs(), which are the key ones, to pass in an
optional unmatefied string; some of the remaining calls in glob.c could
be premoted to pattrylen which is a strict superset of pattry. That
would leave pattry() untouched for the majority of cases doing one-off
matching.
Ideally we only want to pass in either a metafied or unmetafied string.
I don't know off the top of my head how much work it is to fix up the
PAT_PURES optimisation where we've got an already unmetafied string but
it shouldn't be too much.
pws
next prev parent reply other threads:[~2015-09-28 8:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 12:19 Sebastian Gniazdowski
2015-09-26 20:44 ` Bart Schaefer
2015-09-27 8:13 ` Sebastian Gniazdowski
2015-09-27 16:11 ` Bart Schaefer
2015-09-28 8:51 ` Peter Stephenson [this message]
2015-09-28 11:30 ` Peter Stephenson
2015-09-28 19:23 ` Peter Stephenson
2015-09-29 8:44 ` Peter Stephenson
2015-09-29 18:37 ` Peter Stephenson
2015-09-29 19:23 ` Bart Schaefer
2015-09-30 8:59 ` Peter Stephenson
2015-09-30 14:04 ` Peter Stephenson
2015-09-30 21:19 ` Bart Schaefer
2015-10-01 8:41 ` Peter Stephenson
2015-10-01 14:28 ` Heap corruption [the thread formerly known as substitution] Peter Stephenson
2015-10-01 15:07 ` Bart Schaefer
2015-10-01 15:13 ` Peter Stephenson
2015-10-03 18:59 ` Peter Stephenson
2015-10-01 13:45 ` Substitution ${...///} slows down when certain UTF character occurs Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928095142.385a33eb@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).