From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>,
Stephane Chazelas <stephane.chazelas@gmail.com>
Subject: Re: bug with $PWD in /
Date: Mon, 28 Sep 2015 18:13:15 +0000 [thread overview]
Message-ID: <20150928181315.GB4921@tarsus.local2> (raw)
In-Reply-To: <150919134740.ZM23592@torch.brasslantern.com>
Bart Schaefer wrote on Sat, Sep 19, 2015 at 13:47:40 -0700:
> On Sep 19, 8:28pm, Stephane Chazelas wrote:
> } Subject: Re: bug with $PWD in /
> }
> } So, the should recompute $PWD if the one it gets from the
> } environment is a relative path (it's not only about . or ..,
> } think of symlinks).
>
> It'd have to be a symlink from the current directory to itself, tho.
> Other symbolic links are explicitly permitted by the text you quoted.
Looking at the sole caller of ispwd(), setupvals(), it sometimes
initializes $PWD from getenv("HOME"). Is something like this needed,
then?
Or perhaps the condition should be "if not POSIX" rather than "if zsh".
diff --git a/Src/init.c b/Src/init.c
index 22db4b3..24a50c7 100644
--- a/Src/init.c
+++ b/Src/init.c
@@ -1019,7 +1019,7 @@ setupvals(void)
ptr = home;
else
ptr = zgetenv("HOME");
- if (ptr && ispwd(ptr))
+ if (EMULATION(EMULATE_ZSH) && ptr && ispwd(ptr))
pwd = ztrdup(ptr);
else if ((ptr = zgetenv("PWD")) && (strlen(ptr) < PATH_MAX) &&
(ptr = metafy(ptr, -1, META_STATIC), ispwd(ptr)))
next prev parent reply other threads:[~2015-09-28 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 16:26 Stephane Chazelas
2015-09-16 20:37 ` Bart Schaefer
2015-09-16 20:56 ` Bart Schaefer
2015-09-19 18:08 ` Bart Schaefer
2015-09-19 19:28 ` Stephane Chazelas
2015-09-19 20:47 ` Bart Schaefer
2015-09-28 18:13 ` Daniel Shahaf [this message]
2015-09-28 22:04 ` Bart Schaefer
2015-09-19 20:01 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928181315.GB4921@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=schaefer@brasslantern.com \
--cc=stephane.chazelas@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).