From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18442 invoked by alias); 6 Oct 2015 19:52:32 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36808 Received: (qmail 22708 invoked from network); 6 Oct 2015 19:52:30 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Originating-IP: [80.3.228.158] X-Spam: 0 X-Authority: v=2.1 cv=RLtOZNW+ c=1 sm=1 tr=0 a=P+FLVI8RzFchTbbqTxIDRw==:117 a=P+FLVI8RzFchTbbqTxIDRw==:17 a=NLZqzBF-AAAA:8 a=kj9zAlcOel0A:10 a=q2GGsy2AAAAA:8 a=KGTUw_SSZBsP6XbUpiUA:9 a=CjuIK1q_8ugA:10 Date: Tue, 6 Oct 2015 20:46:54 +0100 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: syntax check of 'echo $HOME' crashes in ksh emulation mode Message-ID: <20151006204654.09781f00@ntlworld.com> In-Reply-To: <151006083446.ZM5523@torch.brasslantern.com> References: <1693579.IilOBOKrgc@kdudka.brq.redhat.com> <20151005174219.69ae85c4@pwslap01u.europe.root.pri> <151005104507.ZM19176@torch.brasslantern.com> <20151006093357.0c7a5214@pwslap01u.europe.root.pri> <20151006101549.3664bab3@pwslap01u.europe.root.pri> <151006083446.ZM5523@torch.brasslantern.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 6 Oct 2015 08:34:46 -0700 Bart Schaefer wrote: > } (ii) It's not clear how safe the above is, as this case shows. However, > } it's definitely not safe to skip the tests in assignstrvalue() either > > Do you mean that even for no_exec we should not be bailing out this > early in assignstrvalue()? It's not really clear, but ending up with NULL values in parameters seems a bad thing. However, I dare see we can fix things up as the occur. It's not very helpful. The shell shall read commands but does not execute them; this can be used to check for shell script syntax errors. An interactive shell may ignore this option. But I think there is an argument for setting environment variables in full. pws