zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Bug: bracketed-paste-magic + ztcp causes wrong pasted contents for CJK payloads
Date: Wed, 28 Oct 2015 09:35:04 +0000	[thread overview]
Message-ID: <20151028093504.756c22b1@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <151027202340.ZM17146@torch.brasslantern.com>

On Tue, 27 Oct 2015 20:23:40 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> AHA!
> 
> tcp.c uses setiparam("REPLY"), so depending on whether $REPLY is already
> defined or not, it gets initialized as an integer-typed variable, which
> means that when "self-insert" is assigned to REPLY, it's treated as an
> arithmetic expression and evaluates to 0.

I even noticed this the other day and got confused by it when playing
with ztcp myself, and nearly mentioned it.

I suspect the biggest problem is when you do stuff from the command line,
but it can obviously turn up anywhere.

> tcp.c, socket.c, and zpty.c all use setiparam("REPLY"), potentially
> inflicting this on other modules that later do setsparam("REPLY").  Yet
> another reason for Kurtis to run for the hills.

Or you could interpret it as a reason for warncreateglobal.  Does that
go off correctly if you set it?  If not, we might want to try to get it
to, even if we take the setitparam()s out.

I'd be inclined to get rid of this.  There's no good reason for using an
integer parameter for something that doesn't need to be involved in
arithmetic evaluation at all as it's going to spend its life just as a
number of no more than a couple of digits.

pws


  reply	other threads:[~2015-10-28  9:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 13:54 Chi Hsuan Yen
2015-10-15 20:54 ` Bart Schaefer
2015-10-16  0:25   ` Bart Schaefer
2015-10-16 19:40     ` Chi Hsuan Yen
2015-10-18 15:52       ` Bart Schaefer
2015-10-18 16:19         ` Chi Hsuan Yen
2015-10-28  2:43     ` Bart Schaefer
2015-10-28  3:23       ` Bart Schaefer
2015-10-28  9:35         ` Peter Stephenson [this message]
2015-10-28 17:07           ` Bart Schaefer
2015-10-28 17:44             ` Peter Stephenson
2015-10-28 23:38               ` Bart Schaefer
2015-10-29  9:31                 ` Peter Stephenson
2015-10-29 14:51                   ` Peter Stephenson
2015-10-29 15:00                     ` Bart Schaefer
2015-10-29 15:10                       ` Peter Stephenson
2015-10-29 16:25                     ` Jun T.
2015-10-29 16:56                       ` Peter Stephenson
2015-10-30 15:02                         ` Daniel Shahaf
2015-11-03 16:31                           ` Chi Hsuan Yen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028093504.756c22b1@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).