zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: zsh-workers@zsh.org
Subject: Re: Bug: bracketed-paste-magic + ztcp causes wrong pasted contents for CJK payloads
Date: Fri, 30 Oct 2015 15:02:03 +0000	[thread overview]
Message-ID: <20151030150203.GB1462@tarsus.local2> (raw)
In-Reply-To: <20151029165625.67eb2e43@pwslap01u.europe.root.pri>

Peter Stephenson wrote on Thu, Oct 29, 2015 at 16:56:25 +0000:
> On Fri, 30 Oct 2015 01:25:49 +0900
> Jun T. <takimoto-j@kba.biglobe.ne.jp> wrote:
> > E01options.ztst also need be updated; otherwise it fails as follows:
> > 
> > *** /tmp/zsh.ztst.err.65239	Fri Oct 30 00:54:52 2015
> > --- /tmp/zsh.ztst.terr.65239	Fri Oct 30 00:54:52 2015
> > ***************
> > *** 1,3 ****
> > --- 1,4 ----
> >   fn:3: scalar parameter foo1 created globally in function
> >   fn:5: scalar parameter foo1 created globally in function
> >   fn:15: math parameter foo5 created globally in function fn
> > + fn:15: numeric parameter foo5 created globally in function
> 
> Hmmm... I must have been asleep when the math test was added, since
> there's no reason at all why it should be inconsistent with the others.
> Either report the function or not.
> 
> -?fn:3: scalar parameter foo1 created globally in function
> -?fn:5: scalar parameter foo1 created globally in function
> -?fn:15: math parameter foo5 created globally in function fn
> +?fn:3: scalar parameter foo1 created globally in function fn
> +?fn:5: scalar parameter foo1 created globally in function fn
> +?fn:15: numeric parameter parameter foo5 created globally in function fn

Thanks for improving it ☺

I'll fix the "numeric parameter parameter" thing.

> This ports the code to report the function.  The math-specific code is
> no longer needed now we have a check in setnparam().  I've been
> overcautious since I can't see why we'd fail to find a function
> on the trace stack if locallevel is non-zero.

I can't see when that would happen, either; the reason for the NULL
checks might be, more than anything else, that I wasn't familiar with
the C funcstack data structure.

Thanks,

Daniel


  reply	other threads:[~2015-10-30 15:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 13:54 Chi Hsuan Yen
2015-10-15 20:54 ` Bart Schaefer
2015-10-16  0:25   ` Bart Schaefer
2015-10-16 19:40     ` Chi Hsuan Yen
2015-10-18 15:52       ` Bart Schaefer
2015-10-18 16:19         ` Chi Hsuan Yen
2015-10-28  2:43     ` Bart Schaefer
2015-10-28  3:23       ` Bart Schaefer
2015-10-28  9:35         ` Peter Stephenson
2015-10-28 17:07           ` Bart Schaefer
2015-10-28 17:44             ` Peter Stephenson
2015-10-28 23:38               ` Bart Schaefer
2015-10-29  9:31                 ` Peter Stephenson
2015-10-29 14:51                   ` Peter Stephenson
2015-10-29 15:00                     ` Bart Schaefer
2015-10-29 15:10                       ` Peter Stephenson
2015-10-29 16:25                     ` Jun T.
2015-10-29 16:56                       ` Peter Stephenson
2015-10-30 15:02                         ` Daniel Shahaf [this message]
2015-11-03 16:31                           ` Chi Hsuan Yen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151030150203.GB1462@tarsus.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).