zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Bug in alias expansion
Date: Wed, 18 Nov 2015 14:13:23 +0000	[thread overview]
Message-ID: <20151118141323.04bda5aa@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20151118104254.4a46d326@pwslap01u.europe.root.pri>

On Wed, 18 Nov 2015 10:42:54 +0000
Peter Stephenson <p.stephenson@samsung.com> wrote:
> > Addendum:  To some extent it does not.
> > 
> > torch% alias foo='echo x)$(:'
> > torch% print $(foo)
> > zsh: command not found: fooecho
> 
> This is a completely different problem again.  There appear to be three
> different but interacting issues:
> 
> - this one, which could be hairy as we emerge from parsing a $(...)
> expansion with an alias unpopped --- I'm not sure yet if that's
> tractable without making the code yet more unreadable

Actually, now I start looking, I think I'm inclining to Mikael's view on
the interaction between this and the position of alias expansion, even
if it's global.  At the top level we have $(, foo, ).  foo clearly
starts within the $(.  So it's hard to see how the $( can then end
within the foo; it seems to violate the hierarchy.  Yes, I know aliases
can violate hierarchies, but only once they're expanded, obviously.  I
can't see a sensible reason for expanding foo until we're already within
the context of the $(...) --- surely the intention of $(...) is to
protect the outside world from whatever's inside, and if foo isn't
inside I'm no longer sure which way up I am.

Currently we expand both when parsing the entrails of the $(...)
and executing it, but should possibly only do so in the latter case.
I haven't look to see if this affects any tests.

pws


  reply	other threads:[~2015-11-18 14:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 18:03 Kynn Jones
2015-11-14  1:03 ` Bart Schaefer
2015-11-14 18:57   ` Kynn Jones
2015-11-14 19:03     ` Bart Schaefer
2015-11-14 19:19       ` Kynn Jones
2015-11-14 21:40         ` Bart Schaefer
2015-11-14 22:20           ` Kynn Jones
2015-11-15 20:03 ` Peter Stephenson
2015-11-15 21:52   ` Bart Schaefer
2015-11-15 22:26     ` Bart Schaefer
2015-11-15 22:48   ` Bart Schaefer
2015-11-16  0:50     ` Mikael Magnusson
2015-11-16  3:24       ` Bart Schaefer
2015-11-16  5:42         ` Mikael Magnusson
2015-11-18 10:42     ` Peter Stephenson
2015-11-18 14:13       ` Peter Stephenson [this message]
2015-11-18 15:52         ` Bart Schaefer
2015-11-18 16:14           ` Peter Stephenson
2015-11-18 18:09             ` Bart Schaefer
2015-11-17 17:29   ` Peter Stephenson
2015-11-18  4:55     ` Bart Schaefer
2015-11-18 10:30       ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151118141323.04bda5aa@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).