From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19123 invoked by alias); 20 Nov 2015 11:49:54 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 37168 Received: (qmail 2436 invoked from network); 20 Nov 2015 11:49:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-AuditID: cbfec7f4-f79026d00000418a-a5-564f08de7713 Date: Fri, 20 Nov 2015 11:49:48 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: WARN_CREATE_GLOBAL and parameters used by the shell Message-id: <20151120114948.6edc448a@pwslap01u.europe.root.pri> In-reply-to: <20151120114456.GA24924@cventin.lip.ens-lyon.fr> References: <20151120114456.GA24924@cventin.lip.ens-lyon.fr> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t/xq7r3OPzDDGbu07c42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGbs//mMumM5acffmXbYGxmaWLkZODgkBE4mzJ9+yQ9hiEhfu rWfrYuTiEBJYyihx+9wSFghnBpPEw5UnWSGcc4wS31tnQzlnGSXa3t9n6mLk4GARUJVo2asF MopNwFBi6qbZjCC2iIC4xNm158HWCQs4SHxfNJMNxOYVsJfof/IALM4pYCsxc+sLMFtIwEZi xYpesJP4BfQlrv79xARxnr3EzCtnGCF6BSV+TL4HVs8soCWxeVsTK4QtL7F5zVtmiDnqEjfu 7mafwCg8C0nLLCQts5C0LGBkXsUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kREs5fdjAuPmZ1 iFGAg1GJh7dB3C9MiDWxrLgy9xCjBAezkgjvgXdAId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxz d70PERJITyxJzU5NLUgtgskycXBKNTCusz7Z8LjXX0r5bL6/0MdITvdvwpxTzVO+Fzi3KdfN a9eqrOgMmXDdO1Qw9PDGe4KnPV83H6sQ//FEPHu2+sNmAc0sEfscXb3eWZMeLSuJvb5s5m7J eRvDtxcV7+9df/DZGV6zvRLLFTq7vof/LNJ8mPP3wAnHoFsa4e1BwUXTt8juerpvl5sSS3FG oqEWc1FxIgC5BwmNYwIAAA== On Fri, 20 Nov 2015 12:44:56 +0100 Vincent Lefevre wrote: > I think that when WARN_CREATE_GLOBAL is set, one should get no warnings > for parameters used by the shell, as their intent is to be global. Yes, we need to ignore specials, which are already in the namespace anyway. pws diff --git a/Src/params.c b/Src/params.c index 3ed771e..b121bd6 100644 --- a/Src/params.c +++ b/Src/params.c @@ -2702,7 +2702,7 @@ check_warn_create(Param pm, const char *pmtype) Funcstack i; const char *name; - if (pm->level != 0) + if (pm->level != 0 || (pm->node.flags & PM_SPECIAL)) return; name = NULL;