zsh-workers
 help / color / mirror / code / Atom feed
From: Danek Duvall <duvall@comfychair.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: Actually do test what I claimed to test
Date: Thu, 26 Nov 2015 12:13:49 -0800	[thread overview]
Message-ID: <20151126201349.GB12122@lorien.comfychair.org> (raw)
In-Reply-To: <151126092636.ZM12534@torch.brasslantern.com>

On Thu, Nov 26, 2015 at 09:26:36AM -0800, Bart Schaefer wrote:

> The test I added in 37208 wasn't doing what I intended.
> 
> Anyone see a portability problem with my use of "sed" here?

Doesn't work on Solaris unless you scrap the space between the "a" and the
backslash.  Then it seems to do the trick, and with GNU sed, too.

Danek

> 
> diff --git a/Test/V10private.ztst b/Test/V10private.ztst
> index f877455..d5bee5e 100644
> --- a/Test/V10private.ztst
> +++ b/Test/V10private.ztst
> @@ -6,12 +6,17 @@
>     ZTST_unimplemented="can't load the zsh/param/private module for testing"
>   fi
>  
> + # Do not use .tmp here, ztst.zsh will remove it too soon (see %cleanup)
> + mkdir private.TMP
> + sed '/^%prep/a \
> +  zmodload zsh/param/private' < $ZTST_srcdir/B02typeset.ztst > private.TMP/B02
> +
>  %test
>  
>   (zmodload -u zsh/param/private && zmodload zsh/param/private)
>  0:unload and reload the module without crashing
>  
> - $ZTST_exe +Z -f $ZTST_srcdir/ztst.zsh $ZTST_srcdir/B02typeset.ztst
> + ZTST_verbose=0 $ZTST_exe +Z -f $ZTST_srcdir/ztst.zsh private.TMP/B02
>  0:typeset still works with zsh/param/private module loaded
>  *>*
>  *>*
> @@ -270,3 +275,7 @@ F:note "typeset" rather than "private" in output from outer
>  
>   () { private -h SECONDS }
>  0:private parameter may hide a special parameter
> +
> +%clean
> +
> +  rm -r private.TMP


  parent reply	other threads:[~2015-11-26 20:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 17:26 Bart Schaefer
2015-11-26 18:04 ` Peter Stephenson
2015-11-26 20:13 ` Danek Duvall [this message]
2015-11-27  8:09   ` Jun T.
2015-11-27 10:32     ` Bart Schaefer
2015-11-27 10:57       ` Jun T.
2015-11-27 11:32       ` Peter Stephenson
2015-11-27 19:10         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151126201349.GB12122@lorien.comfychair.org \
    --to=duvall@comfychair.org \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).