zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: Array appends are quadratic
Date: Sat, 28 Nov 2015 19:36:52 +0000	[thread overview]
Message-ID: <20151128193652.777742be@ntlworld.com> (raw)
In-Reply-To: <20151128180517.GL2498@tarsus.local2>

On Sat, 28 Nov 2015 18:05:17 +0000
Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> The effort involved in implementing the redoubling allocation (for the
> other problem indicated in 37236) would be similar: mainly having the
> array remember the number of allocated slots.  I'll have to track done
> all places in the code that allocate/reallocate arrays, hopefully there
> aren't too many.

I suspect (though I haven't actually done a search) you're out of luck
here, as there's a wide assumption that null-terminated char **'s are
the the way to carray a fixed number of elements with generic contents
that might get presented to the user.  See for example the number of
uses of mkarry().

Not allocating when the size hasn't changed should be much easier and is
easy to test for.

pws


  reply	other threads:[~2015-11-28 19:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27  7:37 Daniel Shahaf
2015-11-27  8:26 ` Mikael Magnusson
2015-11-27 10:59   ` Bart Schaefer
2015-11-28 18:05     ` Daniel Shahaf
2015-11-28 19:36       ` Peter Stephenson [this message]
2015-11-30  3:20         ` Daniel Shahaf
2015-12-03 23:36         ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151128193652.777742be@ntlworld.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).