From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-37255-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 8664 invoked by alias); 30 Nov 2015 09:48:41 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 37255
Received: (qmail 1110 invoked from network); 30 Nov 2015 09:48:40 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.0
X-AuditID: cbfec7f5-f79b16d000005389-b9-565c19171b60
Date: Mon, 30 Nov 2015 09:38:32 +0000
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 3/3] Constify two local variables.
Message-id: <20151130093832.5321126d@pwslap01u.europe.root.pri>
In-reply-to: <20151130032153.GH2504@tarsus.local2>
References: <20151130032153.GH2504@tarsus.local2>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t/xa7rikjFhBnNnWFocbH7I5MDoserg
	B6YAxigum5TUnMyy1CJ9uwSujKeP77IVrGSrmPf6GmsDYxNrFyMnh4SAicTBjQuZIGwxiQv3
	1rN1MXJxCAksZZR42TCRFcKZwSRxeNFRqMw5oMyyOVDOWUaJJxOOsYP0swioSvx/OJ8FxGYT
	MJSYumk2I4gtIiAucXbtebC4sICZxMGWpWD1vAL2ErOPHgKr4RQwknjbORusRgik93w7M4jN
	L6AvcfXvJ6j77CVmXjnDCNErKPFj8j2wemYBLYnN2yD+YRaQl9i85i0zxBx1iRt3d7NPYBSe
	haRlFpKWWUhaFjAyr2IUTS1NLihOSs810itOzC0uzUvXS87P3cQICeivOxiXHrM6xCjAwajE
	wythFh0mxJpYVlyZe4hRgoNZSYRXiC8mTIg3JbGyKrUoP76oNCe1+BCjNAeLkjjvzF3vQ4QE
	0hNLUrNTUwtSi2CyTBycUg2M+e5LGxweRqRISyuHtHbccJ21LdXwxlbFsxrWHWaHHvC1s4tm
	tmyeZu4zX8Yq91fOIRm1qVr7lev253qoz9894RtjnaIH/6GDq1lzTdzV4g6dt2yZdOpp3I32
	ZpOv984G2brvubhb8diMx5E/FI6Jvuzfmnf445vDql3+X1n5/ufXr7rBzP9EiaU4I9FQi7mo
	OBEAfPpMD2QCAAA=

On Mon, 30 Nov 2015 03:21:53 +0000
Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> I assume that v->pm->gsu.a->getfn() has no access to v->start and
> v->end, hence changing the order is safe.

Yes, the getfn() is very low level, dealing only with storage for that
parameter and having no knowledge at all of any expansion/substitution
happening above it.

> Are there any compilers that choke on 'char **const' (const pointer to pointer
> to char)?

I suspect we ditched those some years ago when we started making more
use of const, but there might be a few oddballs lying around.

By the way...

> See for example the number of uses of mkarry()

that should have been "mkarray()".  I see 19 uses, then there's
also hmkarray() which comes from the heap and is only used 3 times.

pws