From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8527 invoked by alias); 8 Dec 2015 12:57:59 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 37347 Received: (qmail 8875 invoked from network); 8 Dec 2015 12:57:58 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-AuditID: cbfec7f4-f79026d00000418a-ce-5666d3d3c75d Date: Tue, 08 Dec 2015 12:57:52 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: [Bug] VCS_Info: nvcsformats ineffective on zsh 5.2 Message-id: <20151208125752.072a1096@pwslap01u.europe.root.pri> In-reply-to: <87vb899l9r.fsf@swiftsure.meterriblecrew.net> References: <87vb899l9r.fsf@swiftsure.meterriblecrew.net> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t/xy7qXL6eFGfR/YbE42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGTe3Lmcs6OWsWL3wIEsD4zb2LkZODgkBE4kbDdtYIWwxiQv3 1rN1MXJxCAksZZTouNfECOHMYJKY3vudBcI5zSjx4WQHlHOGUeL2jhtg/SwCqhKb3r1jAbHZ BAwlpm6azQhiiwiIS5xdex4sLixgL7H1+AUwmxfIXrf4I5jNKWAl8e/eWrCbhAQsJc7NPgwW 5xfQl7j69xMTxH32EjOvnGGE6BWU+DH5HlgNs4CWxOZtTawQtrzE5jVvmSHmqEvcuLubfQKj 8CwkLbOQtMxC0rKAkXkVo2hqaXJBcVJ6rqFecWJucWleul5yfu4mRkhAf9nBuPiY1SFGAQ5G JR7eE8dSw4RYE8uKK3MPMUpwMCuJ8PZdSgsT4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjt31/sQ IYH0xJLU7NTUgtQimCwTB6dUA6OoqVdJTbTY/8XSxumMvJoXTjxbw36o8LTFQk3z4NLtbXNj Nra4uXlYHTZ581Az949S5FbzhY3vLHJPpr2qvZg19c6h0OS0gqttgTcyfl7s5v+5Z23KCc03 dTu/VavFvExsbg+JO+D+/n+dvfSenDLXbqGOWYs2M0hPfXxy0+ypj96nM7ufEldiKc5INNRi LipOBAAzgNmPZAIAAA== On Tue, 8 Dec 2015 13:29:04 +0100 Andreas Wiese wrote: > In zsh 5.2, VCS_info's `nvcsformats' is broken, resp. disfunctional. > It will always evaluate to ''. Removing the line > > local -a msgs > > from Functions/VCS_Info/VCS_INFO_nvcsformats introduced in commit > ae4cf7b7 leads to the wanted behaviour. I did not fully understand the > sense between the introduced line and the cause for the misbehaviour, > though. Hmmm... Mikael added a "local -a msgs" to the level above that should have made the warning from this variable to go away. But obviously it needs not to be local here, wherever the warning came from. It's possible whoever reported the fact that it didn't was using an older version of the scripts, I suppose. diff --git a/Functions/VCS_Info/VCS_INFO_nvcsformats b/Functions/VCS_Info/VCS_INFO_nvcsformats index 203a86d..581aa5a 100644 --- a/Functions/VCS_Info/VCS_INFO_nvcsformats +++ b/Functions/VCS_Info/VCS_INFO_nvcsformats @@ -4,7 +4,6 @@ setopt localoptions noksharrays NO_shwordsplit local c v rr -local -a msgs if [[ $1 == '-preinit-' ]] ; then c='default'