From: Axel Beckert <abe@deuxchevaux.org>
To: zsh-workers@zsh.org
Cc: Debian Zsh Maintainers <pkg-zsh-devel@lists.alioth.debian.org>
Subject: Re: C02cond.ztst segfaults (was: Re: Strange test suite behaviour since zsh 5.2-dev-1: C02cond.ztst no more reports its finishing)
Date: Mon, 1 Feb 2016 00:20:37 +0100 [thread overview]
Message-ID: <20160131232037.GR4726@sym.noone.org> (raw)
In-Reply-To: <160131151251.ZM12994@torch.brasslantern.com>
Hi Bart,
On Sun, Jan 31, 2016 at 03:12:51PM -0800, Bart Schaefer wrote:
> On Feb 1, 12:03am, Axel Beckert wrote:
> } Program terminated with signal SIGSEGV, Segmentation fault.
> } #1 0x000055e7dc4af8f4 in is_cond_binary_op (str=0x7f05376fe238 "non-empty-string") at ../../Src/text.c:63
>
> Try this:
>
> diff --git a/Src/text.c b/Src/text.c
> index 04acd2a..cf6d3eb 100644
> --- a/Src/text.c
> +++ b/Src/text.c
> @@ -47,7 +47,7 @@ int text_expand_tabs;
> */
> static const char *cond_binary_ops[] = {
> "=", "!=", "<", ">", "-nt", "-ot", "-ef", "-eq",
> - "-ne", "-lt", "-gt", "-le", "-ge", "=~"
> + "-ne", "-lt", "-gt", "-le", "-ge", "=~", NULL
> };
>
> static char *tptr, *tbuf, *tlim, *tpending;
Thanks! That fixed at least my local segfault when compiling with
-fPIE. Will now push that patch to our Jenkins. Hopefully this also
fixes the 32-bit C02cond.ztst issues, at least the symptoms are the
same.
Kind regards, Axel
--
/~\ Plain Text Ribbon Campaign | Axel Beckert
\ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail)
X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \ I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)
next prev parent reply other threads:[~2016-01-31 23:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 20:19 Strange test suite behaviour since zsh 5.2-dev-1: C02cond.ztst no more reports its finishing Axel Beckert
2016-01-31 20:51 ` Bart Schaefer
2016-01-31 21:59 ` Axel Beckert
2016-01-31 23:03 ` C02cond.ztst segfaults (was: Re: Strange test suite behaviour since zsh 5.2-dev-1: C02cond.ztst no more reports its finishing) Axel Beckert
2016-01-31 23:12 ` Bart Schaefer
2016-01-31 23:20 ` Axel Beckert [this message]
2016-02-01 0:18 ` Axel Beckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160131232037.GR4726@sym.noone.org \
--to=abe@deuxchevaux.org \
--cc=pkg-zsh-devel@lists.alioth.debian.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).