From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: PATCH: rm * with count
Date: Thu, 11 Feb 2016 11:50:13 +0000 [thread overview]
Message-ID: <20160211115013.05e0ce7f@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <160210132048.ZM3836@torch.brasslantern.com>
On Wed, 10 Feb 2016 13:20:48 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Feb 10, 4:41pm, Peter Stephenson wrote:
> } Subject: PATCH: rm * with count
> }
> } Faced with a "rm *" prompt, it occurred to me it might be a little bit
> } more helpful to decide if something has gone really horribly wrong if we
> } made the easy tweak to count the number of files in the directory.
> }
> } Any comments on the following?
>
> My only comment would be that this can potentially take a long time if
> the number of files in the directory is large. Perhaps stop after some
> number (100?) and prompt with
>
> "sure you want to delete more than %d files in "
It can certainly be slow if it's on a network, although it's going to
have to do the full glob anyway if it actually executes the command.
> Also if the count is zero maybe the prompt should say something about
> "no files to remove" or something.
I didn't feel it was quite the job of this test to say things like "I
can't actually find that directory" or "I've found it but it's empty";
it was starting to get too fiddly and not really adding to safety, which
was the primary purpose.
pws
diff --git a/Src/utils.c b/Src/utils.c
index de4af5a..12911d3 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -2634,13 +2634,36 @@ zsleep_random(long max_us, time_t end_time)
int
checkrmall(char *s)
{
+ DIR *rmd;
+ int count = 0;
if (!shout)
return 1;
- fprintf(shout, "zsh: sure you want to delete all the files in ");
if (*s != '/') {
- nicezputs(pwd[1] ? pwd : "", shout);
- fputc('/', shout);
- }
+ if (pwd[1])
+ s = zhtricat(pwd, "/", s);
+ else
+ s = dyncat("/", s);
+ }
+ const int max_count = 100;
+ if ((rmd = opendir(unmeta(s)))) {
+ int ignoredots = !isset(GLOBDOTS);
+ while (zreaddir(rmd, ignoredots)) {
+ count++;
+ if (count > max_count)
+ break;
+ }
+ closedir(rmd);
+ }
+ if (count > max_count)
+ fprintf(shout, "zsh: sure you want to delete more than %d files in ",
+ max_count);
+ else if (count == 1)
+ fprintf(shout, "zsh: sure you want to delete the only file in ");
+ else if (count > 0)
+ fprintf(shout, "zsh: sure you want to delete all %d files in ",
+ count);
+ else
+ fprintf(shout, "zsh: sure you want to delete all the files in ");
nicezputs(s, shout);
if(isset(RMSTARWAIT)) {
fputs("? (waiting ten seconds)", shout);
prev parent reply other threads:[~2016-02-11 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 16:41 Peter Stephenson
2016-02-10 21:20 ` Bart Schaefer
2016-02-11 11:50 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211115013.05e0ce7f@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).