zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Segfault on completion with interactive mode
Date: Thu, 11 Feb 2016 12:49:48 +0000	[thread overview]
Message-ID: <20160211124948.278fb707@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <160210200147.ZM8455@torch.brasslantern.com>

What I saw when I tried this was a crash in singledraw() because
mgtab[0] was 1, suggesting it as a "marked" null pointer.  So presumably
this state is incompatible with state required when we call
singledraw(),

    if (!mnew && inselect && onlnct == nlnct && mlbeg >= 0 && mlbeg == molbeg)
        singledraw();

This appears to be a lot later than anything you're talking about.

Preumably that pile of stuff in complistmatches inside "if (mnew) {" is
the key to what should be consistent.  It sounds like in the code you're
talking about, that code had just run, because mtab_been_reallocated was
1, whereas this time round, when it crashes, it hadn't.
("mtab_been_reallocated" seems to be associated with the 'if you've got
global variables you don't really need a calling convention' programming
style.)

So at the level I'm looking at it, it looks vaguely like it's in a state
as if "mnew" has just been set, in which case we'd skip the
singledraw(), and somehow we've got back too soon before all the stuff
that happens after to fix it up, whatever that is.

Anyway, the summary is I've completely failed to understand even the
most basic points of the logic that sets up the completion list
consistently.

pws


  reply	other threads:[~2016-02-11 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 16:40 Óscar García Amor
2016-02-10 20:03 ` Bart Schaefer
2016-02-11  4:01 ` Bart Schaefer
2016-02-11 12:49   ` Peter Stephenson [this message]
2016-02-12 10:17     ` Bart Schaefer
2016-02-13 22:28 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160211124948.278fb707@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).