From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38079-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 3678 invoked by alias); 3 Mar 2016 17:47:41 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38079
Received: (qmail 27329 invoked from network); 3 Mar 2016 17:47:40 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.1
X-AuditID: cbfec7f4-f79026d00000418a-06-56d8765d22a8
Date: Thu, 03 Mar 2016 17:37:30 +0000
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: ZSH_SCRIPT
Message-id: <20160303173730.45a8c8ee@pwslap01u.europe.root.pri>
In-reply-to: <87mvqflbgh.fsf@lwm.klanderman.net>
References: <22221.59800.803540.618862@lwm.klanderman.net>
 <160224143153.ZM28994@torch.brasslantern.com>
 <20160225093344.0d2499d5@pwslap01u.europe.root.pri>
 <87r3g08ycp.fsf@lwm.klanderman.net>
 <160225150425.ZM14095@torch.brasslantern.com>
 <87lh6384y5.fsf@lwm.klanderman.net>
 <20160301092746.1472ae95@pwslap01u.europe.root.pri>
 <87fuwa8dpk.fsf@lwm.klanderman.net>
 <20160301150707.2ee18f01@pwslap01u.europe.root.pri>
 <56D74063.6020202@inlv.org> <871t7s7ev6.fsf@lwm.klanderman.net>
 <20160303093702.7d28f80e@pwslap01u.europe.root.pri>
 <87mvqflbgh.fsf@lwm.klanderman.net>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t/xq7qxZTfCDO7sYbE42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGRtPn2Iu2Mdacf1VE0sD4yqWLkZODgkBE4nVHR/ZIGwxiQv3
	1gPZXBxCAksZJb6/380O4cxgklizYRczhHOaUWLDhi2sEM4ZRolvF9eBzWIRUJV4vOgXM4jN
	JmAoMXXTbEYQW0RAXOLs2vNgNcJA9sUPM9lBbF4Be4nD3z6B7eYUMJDYtP0mI9RQFomzN6+C
	NfAL6Etc/fuJCeJAe4mZV84wQjQLSvyYfA+shllAS2LztiZWCFteYvOat2BHCAmoS9y4u5t9
	AqPwLCQts5C0zELSsoCReRWjaGppckFxUnquoV5xYm5xaV66XnJ+7iZGSEh/2cG4+JjVIUYB
	DkYlHt4bDdfDhFgTy4orcw8xSnAwK4nwHim5ESbEm5JYWZValB9fVJqTWnyIUZqDRUmcd+6u
	9yFCAumJJanZqakFqUUwWSYOTqkGRv8pDd9Mwx+JL/LJnKdhEisQ/OeDjPFxE8tljUxzvFax
	uak9ttW4GVLxruvW3uhC1uWlTnO3qnVaGfGqhU0+6buE2/T1/FdW3dMuZ0q/9uLO3SQcHV+3
	rO/VhJdyWobH/68pW+u/biNLRZt/y7rTyVarlhgsOycR+uuF40yxV2c73IoMLkzKUWIpzkg0
	1GIuKk4EAFr3qy9lAgAA

On Thu, 3 Mar 2016 12:26:22 -0500
Greg Klanderman <gak@klanderman.net> wrote:
> Peter/Bart do you think it needs both ztrdup()s?
> 
> in zsh_main():
>     zsh_script = ztrdup(runscript);
> 
> and in createparamtable():
>     setsparam("ZSH_SCRIPT", ztrdup(zsh_script));

I think it needs the second, because what you pass to a parameter needs
to be uniquely managed by that parameter, so it can't point to memory
that can be referenced another way.  I doubt it needs the first as well.

Actually, I don't see why you need a glboal for zsh_script at all.  It's
just there to pass runscript on so it can be set later.  That's better
done by passing arguments rather than globals.

pws