From: Peter Stephenson <p.stephenson@samsung.com>
To: Baruch Siach <baruch@tkos.co.il>, zsh-workers@zsh.org
Subject: Re: [PATCH] configure: use user set pcre-config
Date: Fri, 04 Mar 2016 12:05:37 +0000 [thread overview]
Message-ID: <20160304120537.1829da7f@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <c0c1502c12c4fd12726930a3338fc9dbef58031e.1457041047.git.baruch@tkos.co.il>
On Thu, 3 Mar 2016 23:37:27 +0200
Baruch Siach <baruch@tkos.co.il> wrote:
> Setting a non default configuration script location is common practice when
> cross compiling, since the target library might need different flags. zsh
> configure scripts allows the user to set pcre-config location but doesn't
> actually use it. Fix this.
Thanks, that looks fine and I've committed it.
I wonder if we should be doing something similar further up? I was
evidently a bit tentative when I committed the code here since it
insists only on tweaking the flags if the pcre-config set up was
standard. But I don't know this is actually a problem.
if test x$enable_pcre = xyes; then
AC_CHECK_PROG([PCRECONF], pcre-config, pcre-config)
dnl Typically (meaning on this single RedHat 9 box in front of me)
dnl pcre-config --cflags produces a -I output which needs to go into
dnl CPPFLAGS else configure's preprocessor tests don't pick it up,
dnl producing a warning.
if test "x$ac_cv_prog_PCRECONF" = xpcre-config; then
CPPFLAGS="$CPPFLAGS `pcre-config --cflags`"
fi
fi
pws
prev parent reply other threads:[~2016-03-04 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 21:37 Baruch Siach
2016-03-04 12:05 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304120537.1829da7f@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=baruch@tkos.co.il \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).