From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Signal handling bugaboo in command substitution
Date: Wed, 09 Mar 2016 09:55:06 +0000 [thread overview]
Message-ID: <20160309095506.305d64c8@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <CAH+w=7YCFciaFG8xMFqAefj2pK2ODkwWRM=2kiA+oGDQcxaB7Q@mail.gmail.com>
On Tue, 08 Mar 2016 09:30:42 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Tue, Mar 8, 2016 at 2:12 AM, Peter Stephenson
> <p.stephenson@samsung.com> wrote:
> >
> > Actually, probably ESUB_NOMONITOR should take precedence. That's really
> > not a good place to allow this stuff, no matter who thought it might be...
>
> Aside from the spurious ChangeLog diff and the inconsistent
> left-curly-brace cuddling, this seems to do what was intended.
It occurs to me there's probably still a very thin race associated with
forking and then calling entersubsh() that may be wider than just this
case. We'd need to queue signals before the fork and unqueue them in
both parent and child at the end of entersubsh(). It might well be more
trouble than it's worth to fix.
pws
next prev parent reply other threads:[~2016-03-09 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 2:44 Bart Schaefer
2016-03-08 10:00 ` Peter Stephenson
2016-03-08 10:12 ` Peter Stephenson
2016-03-08 17:30 ` Bart Schaefer
2016-03-09 9:55 ` Peter Stephenson [this message]
2016-03-09 15:37 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309095506.305d64c8@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).