m0viefreak wrote on Sat, Apr 16, 2016 at 18:17:40 +0200: > > > On 11.04.2016 16:25, Bart Schaefer wrote: > > On Apr 11, 6:16am, Daniel Shahaf wrote: > > } Subject: Re: [PATCH] Expose isearch and suffix regions to widgets. > > } > > } m0viefreak wrote on Sun, Apr 10, 2016 at 15:10:39 +0200: > > } > ISEARCH_ACTIVE does not describe the fact that the minibuffer is active, > > } > but the fact that a pattern that was typed in there does actually > > } > matches the BUFFER. > > } > > } Rename the shell parameter, then? > > > > ISEARCH_MATCH ? (I wonder if, like $MATCH, it could contain the actual > > matched string, instead of merely being a boolean.) > > > I think ISEARCH_MATCH would be the ideal name, if the matched string was > exposed, but I haven't found a simple way to do that. > Something like the attached, perhaps? Do you think something like this should be added? (Myself, I'm not sure, since the value would be derivable from the three ISEARCHMATCH_* parameters' values.) > On the other hand, I would also like to keep the _ACTIVE part at the > end, to keep all four of those special parameters named similarly: > > {YANK,SUFFIX,REGION,ISEARCH}_ACTIVE > > What do you think of ISEARCHMATCH_{ACTIVE,START,END}? > > That would still reflect that it's merely a boolean flag, while still > keeping the semantic that it describes the match. I've (rebased and) applied this. We can tweak it further if needed. Cheers, Daniel