zsh-workers
 help / color / mirror / code / Atom feed
From: Matthew Martin <phy1729@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: Bug in C02cont.ztst's -N test
Date: Fri, 29 Apr 2016 20:01:31 -0500	[thread overview]
Message-ID: <20160430010131.GA34472@CptOrmolo.darkstar> (raw)
In-Reply-To: <20160430004639.GA1360@tarsus.local2>

On Sat, Apr 30, 2016 at 12:46:39AM +0000, Daniel Shahaf wrote:
> Bonus points if there's a way to write the condition portably without
> relying on _other_ zsh functionality...

That was discussed on IRC last night.

diff --git a/Test/C02cond.ztst b/Test/C02cond.ztst
index 88cad0d..8343fe2 100644
--- a/Test/C02cond.ztst
+++ b/Test/C02cond.ztst
@@ -23,6 +23,7 @@
   zlnfs=${filetmpprefix}zlnfs
 
   touch $unmodified
+  unmodified_ls="$(ls -lu $unmodified)"
 
   touch zerolength
   chgrp $EGID zerolength
@@ -154,7 +155,7 @@
     ZTST_skip="[[ -N file ]] not supported on Cygwin"
   elif (( isnfs )); then
     ZTST_skip="[[ -N file ]] not supported with NFS"
-  elif { df -k -- ${$({mount || /sbin/mount} | awk '/noatime/ {print $1,$3}'):-""} | tr -s ' ' | fgrep "$(df -k . | tail -1 | tr -s ' ')" } >&/dev/null; then
+  elif sleep 58; [[ $unmodified_ls == "$(ls -lu $unmodified)" ]]; then
     ZTST_skip="[[ -N file ]] not supported with noatime file system"
   else
     [[ -N $newnewnew && ! -N $unmodified ]]

but who wants to sleep for 60 seconds? (There's a sleep 2 earlier.)

- Matthew Martin


  reply	other threads:[~2016-04-30  1:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29  0:20 Jason L Tibbitts III
2016-04-29 20:10 ` Bart Schaefer
2016-04-29 20:29   ` Jason L Tibbitts III
2016-04-29 20:31   ` Jason L Tibbitts III
2016-04-30  0:03     ` Bart Schaefer
2016-04-29 22:38   ` Jason L Tibbitts III
2016-04-30  0:46     ` Daniel Shahaf
2016-04-30  1:01       ` Matthew Martin [this message]
2016-04-30  1:28         ` Daniel Shahaf
2016-04-30  3:51           ` Bart Schaefer
2016-04-30 17:55             ` Bart Schaefer
2016-04-30 18:11               ` Bart Schaefer
2016-05-01  1:48                 ` Daniel Shahaf
2016-05-01  4:42                   ` Bart Schaefer
2016-05-09 13:42                 ` Jun T.
2016-05-09 16:21                   ` Bart Schaefer
2016-05-09 17:32                     ` Jun T.
2016-05-10  3:33                       ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160430010131.GA34472@CptOrmolo.darkstar \
    --to=phy1729@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).