zsh-workers
 help / color / mirror / code / Atom feed
From: Vincent Lefevre <vincent@vinc17.net>
To: zsh-workers@zsh.org
Subject: Re: bracket-paste-magic adds backslashes inside a quoted string if URL is pasted ("regression" compared to pre-5.1 url-quote-magic)
Date: Fri, 13 May 2016 11:23:48 +0200	[thread overview]
Message-ID: <20160513092348.GB18186@zira.vinc17.org> (raw)
In-Reply-To: <160510125848.ZM1686@torch.brasslantern.com>

On 2016-05-10 12:58:48 -0700, Bart Schaefer wrote:
> On May 10, 10:58am, Vincent Lefevre wrote:
> }
> } > We had quite a bit of discussion on related topics when bracketed-paste
> } > was added.  The general idea is that a paste is treated as a unit, and
> } > the default behavior of bracketed-paste-magic is to restrict its action
> } > to remain "inside" that unit.
> } 
> } I'm not sure what you call "unit"
> 
> A single keystroke.  A single widget event.  As if the entire paste, no
> matter how large, is one indivisible object.

But the main point is that there is a context. For instance,
a context can be:

  echo http://localhost/foo

or

  echo 'http://localhost/foo

If I type "?", I expect "\?" to be entered in the first context,
and "?" in the second case. Ditto if "?" is pasted. In both cases,
the action remains inside the unit. So, I don't understand why
bracketed-paste-magic doesn't behave that way by default.

> bracketed-paste-url-magic takes a different approach, examining the
> paste to see if it starts with a URI scheme and if so quoting the
> whole thing, and otherwise not interfering with the default paste
> behavior at all (so you get even less context sensitivity).

bracketed-paste-url-magic is something new to me. I currently have:

  autoload -Uz url-quote-magic
  zle -N self-insert url-quote-magic
  autoload -Uz bracketed-paste-magic
  zle -N bracketed-paste bracketed-paste-magic
  zstyle :bracketed-paste-magic paste-init backward-extend-paste

the only reason of the zstyle line being to get the above expected
behavior when pasting "?". Do you mean that instead of the zstyle
line, bracketed-paste-url-magic would do the work? Does this replace
bracketed-paste-magic or should bracketed-paste-url-magic be used
in addition to bracketed-paste-magic?

bracketed-paste-url-magic is not described in the zsh man pages.

> A third (so far unimplemented) approach would be to examine LBUFFER
> for an unbalanced quote mark and treat the paste accordingly, but
> what exactly does "accordingly" mean?  Escape any quotes of the same
> type that are in the paste, or assume the user is intentionally
> pasting the closing quote?

I would say: the same behavior as url-quote-magic.

URL's normally don't have quotes. For instance, when searching for

  "foo"

or

  'foo'

(with quotes) on Google, Firefox displays the URL's with quotes,
but when I copy-paste these URL's to Emacs, I get:

  https://www.google.fr/#q=%22foo%22
  https://www.google.fr/#q=%27foo%27

and I assume that's Firefox that escapes the quote characters (there
may be a RFC requirement concerning allowed characters in URL's, but
I haven't checked). Note that such escaping is not just useful for
shells, but also for pasting URL's to an XML document in an editor,
since XML attributes also use " and ' quote characters as delimiters.

So, I think that a quote should have its usual shell meaning like
with url-quote-magic (though this could also be configurable).

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)


  reply	other threads:[~2016-05-13  9:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06 20:53 Axel Beckert
2016-05-08 18:50 ` Bart Schaefer
2016-05-09 14:13   ` Vincent Lefevre
2016-05-09 15:41     ` Bart Schaefer
2016-05-10  8:58       ` Vincent Lefevre
2016-05-10 19:58         ` Bart Schaefer
2016-05-13  9:23           ` Vincent Lefevre [this message]
2016-05-13 11:06             ` Bart Schaefer
2016-05-13 12:19               ` Vincent Lefevre
2016-06-02  7:20                 ` undo problems/crashes (was Re: bracket-paste-magic ...) Bart Schaefer
2016-05-13 22:20               ` bracket-paste-magic adds backslashes inside a quoted string if URL is pasted ("regression" compared to pre-5.1 url-quote-magic) Daniel Shahaf
2016-05-14  1:33                 ` Mikael Magnusson
2016-05-14  3:00                   ` Daniel Shahaf
2016-05-15 11:59                     ` Bart Schaefer
2016-05-19 21:14                       ` Daniel Shahaf
2016-06-02  7:06                         ` zle hook conventions (was Re: bracket-paste-magic ...) Bart Schaefer
2016-06-03 20:40                           ` Daniel Shahaf
2016-06-03 22:51                             ` Bart Schaefer
2016-06-04 16:57                               ` Daniel Shahaf
2016-06-10 17:36                           ` Daniel Shahaf
2016-06-10 19:51                             ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160513092348.GB18186@zira.vinc17.org \
    --to=vincent@vinc17.net \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).