From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] add-zle-hook-widget
Date: Tue, 21 Jun 2016 01:41:31 +0000 [thread overview]
Message-ID: <20160621014131.GB17100@tarsus.local2> (raw)
In-Reply-To: <160618162558.ZM5244@torch.brasslantern.com>
Bart Schaefer wrote on Sat, Jun 18, 2016 at 16:25:58 -0700:
> On Jun 16, 10:20pm, Bart Schaefer wrote:
> }
> } What you have convinced me is that in the absence of an explicit index
> } there's some value in retaining the order in which the add-* calls
> } were made, which the code as last pushed doesn't.
>
> The following implements this, as well as fixing some bugs, most notably
> that "setopt ksharrays" broke a bunch of stuff.
>
> There may still be other problems, and of course the discussion with Daniel
> hasn't really finished yet.
Yes, I'm replying as often as I can, but these days that's not as often
as I'd like ☹
> for hook in $hooktypes
> do
> + # Check for an existing widget, add it as the first hook
> + if [[ ${widgets[$hook]} = user:* ]]; then
> + zle -A "$hook" "${widgets[$hook]}"
> + zstyle -- "$hook" widgets 0:"${widgets[$hook]}"
The last parameter expansion should strip the "user:" prefix.
> + zle -N "$hook" azhw:"$hook"
> + fi
Cheers,
Daniel
next prev parent reply other threads:[~2016-06-21 1:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 1:44 Bart Schaefer
2016-06-13 8:52 ` Daniel Shahaf
2016-06-14 18:10 ` Bart Schaefer
2016-06-14 21:06 ` Bart Schaefer
2016-06-15 23:24 ` Daniel Shahaf
2016-06-17 5:20 ` Bart Schaefer
2016-06-18 23:25 ` Bart Schaefer
2016-06-21 1:41 ` Daniel Shahaf [this message]
2016-06-21 22:58 ` Bart Schaefer
2016-06-21 1:41 ` Daniel Shahaf
2016-06-22 20:25 ` Bart Schaefer
2016-07-01 5:11 ` Daniel Shahaf
2016-07-01 20:11 ` Bart Schaefer
2016-07-05 4:57 ` Daniel Shahaf
2016-07-14 7:45 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621014131.GB17100@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).