zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: strptime() on Cygwin requires _XOPEN_SOURCE
Date: Mon, 18 Jul 2016 09:41:42 +0100	[thread overview]
Message-ID: <20160718094142.57773bc4@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <AF9EE581-2824-44FB-9D14-90524F6B0FED@kba.biglobe.ne.jp>

On Sat, 16 Jul 2016 14:34:30 +0900
Jun T. <takimoto-j@kba.biglobe.ne.jp> wrote:
> A possible fix is to define _XOPEN_SOURCE in datetime.c (patch1 below).
> Another possibility is to define _GNU_SOURCE in zsh_system.h (patch2).
> 
> Both work OK on the latest Cygwin, but I can't test on older Cygwin.
> Maybe patch1 is better since it would have minimum side effects?

Probably, yes.  It's really hard to work out what effects a change in
the main header is going to do to all the variety of systems, even if
they're GNU based.

pws


      reply	other threads:[~2016-07-18  8:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-16  5:34 Jun T.
2016-07-18  8:41 ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160718094142.57773bc4@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).